Date: Fri, 22 Jan 2010 04:53:08 +0000 (UTC) From: Ed Schouten <ed@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r202778 - head/lib/libc/gen Message-ID: <201001220453.o0M4r8pi051372@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ed Date: Fri Jan 22 04:53:08 2010 New Revision: 202778 URL: http://svn.freebsd.org/changeset/base/202778 Log: Remove comments about breaking the specification. I've discussed this issue with the Austin Group and it will be fixed in future revisions of the specification. The issue was that ut_line fields weren't supposed to be valid for LOGIN_PROCESS entries, while getutxline() would try to match these records anyway. They also agreed on our way of implementing pututxline() without getutxid() (which other operating systems also do), but unfortunately they disagreed with our way of replacing DEAD_PROCESS entries, which is a pity. The current specification allows the utmpx database to become infinitely big over time. See also: http://austingroupbugs.net/view.php?id=213#c378 Modified: head/lib/libc/gen/utxdb.c Modified: head/lib/libc/gen/utxdb.c ============================================================================== --- head/lib/libc/gen/utxdb.c Fri Jan 22 03:59:05 2010 (r202777) +++ head/lib/libc/gen/utxdb.c Fri Jan 22 04:53:08 2010 (r202778) @@ -83,7 +83,6 @@ utx_to_futx(const struct utmpx *ut, stru case LOGIN_PROCESS: UTOF_ID(ut, fu); UTOF_STRING(ut, fu, user); - /* XXX: bug in the specification? Needed for getutxline(). */ UTOF_STRING(ut, fu, line); UTOF_PID(ut, fu); break; @@ -156,7 +155,6 @@ futx_to_utx(const struct futx *fu) case LOGIN_PROCESS: FTOU_ID(fu, ut); FTOU_STRING(fu, ut, user); - /* XXX: bug in the specification? Needed for getutxline(). */ FTOU_STRING(fu, ut, line); FTOU_PID(fu, ut); break;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001220453.o0M4r8pi051372>