Date: Tue, 21 Apr 2009 10:50:57 -0400 From: Sam Leffler <sam@freebsd.org> To: Bruce Simpson <bms@incunabulum.net> Cc: Dennis Melentyev <dennis.melentyev@gmail.com>, stable@freebsd.org, "current@freebsd.org" <current@freebsd.org>, Maxim Sobolev <sobomax@sippysoft.com> Subject: Re: kernel compile fails without AH_SUPPORT_AR5416 Message-ID: <49EDDD51.9040608@freebsd.org> In-Reply-To: <49ED6AD2.4010006@incunabulum.net> References: <49E6DB25.2010601@sippysoft.com> <b84edfa10904160238u7a94e4aw4f60372a6b99f2a2@mail.gmail.com> <49E6FF8F.4070403@sippysoft.com> <b84edfa10904160505s45bcee01n3e516a00d1e4dffe@mail.gmail.com> <49ED6AD2.4010006@incunabulum.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Simpson wrote: > Hi, > > Looks like I'm late to the party. I was responsible for committing these > ath(4) changes to RELENG_7. > I can't remember if I tested the kernel compile without the > AH_SUPPORT_AR5416 option or not, I have been so incredibly busy. > > Dennis Melentyev wrote: >> 2009/4/16 Maxim Sobolev <sobomax@sippysoft.com>: >> >>> Dennis Melentyev wrote: >>> >>>> Could be worth an entry in UPDATING and/or explicitly added to GENERIC. >>>> >>> My point is that if the option is mandatory for compiling ath(4) driver, >>> then there is no point in having this option in the first place. >>> >> >> Well, fair. >> +1 from me :). >> >> > > So is there a consensus that this seems to break the build for folk who > do not need this option? > If so I can see about committing the necessary changes to turn this > option on by default. I needed the option for what I was trying to do. > > Of course if someone already has a patch for that, that will help, as I > don't have a lot of free time at the moment but can certainly commit a > quick fix if someone already has one. ru had a change to fix this but decided not to; can't say why. Otherwise there is a better way to fix this which I alluded to in previous mail--use the config-generated #define that is generated for the "ath_hal" device. As I said I've not had time to look at that won't probably for several weeks. Either way this requirement has been listed in UPDATING ever since the ath hal source code was imported into the tree. Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49EDDD51.9040608>