Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Jan 2016 10:49:55 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        Sepherosa Ziehau <sephe@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r293719 - head/sys/dev/hyperv/netvsc
Message-ID:  <alpine.BSF.2.00.1601131047330.92377@ai.fobar.qr>
In-Reply-To: <201601120130.u0C1UpvA074721@repo.freebsd.org>
References:  <201601120130.u0C1UpvA074721@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 12 Jan 2016, Sepherosa Ziehau wrote:

> Author: sephe
> Date: Tue Jan 12 01:30:51 2016
> New Revision: 293719
> URL: https://svnweb.freebsd.org/changeset/base/293719
>
> Log:
>  hyperv/hn: Implement LRO
>
>  - Implement the LRO using tcp_lro APIs, and LRO is enabled by default.

Which are only available if INET or INET6 are compiled into the kernel.
Unfortunately this breaks kernel builds that do not include IPv4 or IPv6 support.

Can you please put appropriate #if defined(INET6) || defined(INET)  in place?



>  Differential Revision:	https://reviews.freebsd.org/D4824
>
> Modified:
>  head/sys/dev/hyperv/netvsc/hv_net_vsc.c
>  head/sys/dev/hyperv/netvsc/hv_net_vsc.h
>  head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c

hv_netvsc_drv_freebsd.o: In function `netvsc_recv':
/scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0x483): undefined reference to `tcp_lro_rx'
hv_netvsc_drv_freebsd.o: In function `netvsc_recv_rollup':
/scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0x5ce): undefined reference to `tcp_lro_flush'
hv_netvsc_drv_freebsd.o: In function `netvsc_attach':
/scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0x901): undefined reference to `tcp_lro_init'
hv_netvsc_drv_freebsd.o: In function `netvsc_detach':
/scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0xca8): undefined reference to `tcp_lro_free'
--- kernel ---
*** [kernel] Error code 1
bmake: stopped in /storage/head/obj/scratch/tmp/bz/head.svn/sys/LINT-NOIP


>  head/sys/dev/hyperv/netvsc/hv_rndis.h
>  head/sys/dev/hyperv/netvsc/hv_rndis_filter.c
>  head/sys/dev/hyperv/netvsc/hv_rndis_filter.h



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1601131047330.92377>