Date: Fri, 11 Jan 2019 11:25:00 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Kyle Evans <kevans@freebsd.org> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r342948 - head/share/man/man9 Message-ID: <201901111925.x0BJP0Ac022634@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CACNAnaE8prkwR7GPyt%2B746E9cdT_PHV=hP8DAZBg0VR1RgURgA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Fri, Jan 11, 2019 at 1:13 PM Rodney W. Grimes > <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > Author: imp > > > Date: Fri Jan 11 19:05:40 2019 > > > New Revision: 342948 > > > URL: https://svnweb.freebsd.org/changeset/base/342948 > > > > > > Log: > > > Add man page for device_delete_children. > > > > > > Submitted by: Jeroen Ruigrok van der Werven > > > Differential Revision: https://reviews.freebsd.org/D18452 > > > > > > Added: > > > head/share/man/man9/device_delete_children.9 (contents, props changed) > > > Modified: > > > head/share/man/man9/Makefile > > > > > > Modified: head/share/man/man9/Makefile > > > ============================================================================== > > > --- head/share/man/man9/Makefile Fri Jan 11 16:18:23 2019 (r342947) > > > +++ head/share/man/man9/Makefile Fri Jan 11 19:05:40 2019 (r342948) > > > @@ -90,6 +90,7 @@ MAN= accept_filter.9 \ > > > device_add_child.9 \ > > > DEVICE_ATTACH.9 \ > > > device_delete_child.9 \ > > > + device_delete_children.9 \ > > > DEVICE_DETACH.9 \ > > > device_enable.9 \ > > > device_find_child.9 \ > > > > > > Added: head/share/man/man9/device_delete_children.9 > > > ============================================================================== > > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > > +++ head/share/man/man9/device_delete_children.9 Fri Jan 11 19:05:40 2019 (r342948) > > > @@ -0,0 +1,58 @@ > > > +.\" -*- nroff -*- > > > +.\" > > > +.\" Copyright (c) 2018 Jeroen Ruigrok van der Werven > > > +.\" > > > +.\" All rights reserved. > > > > We should be very carefull about white space between a copyright > > statement and the All Rights reserved clause of that copyright > > statement (we actual prefer not to have those words) as this > > leads to Copyrights inserted between the 2 which disjoin the > > all rights reserved from the copyright that is asserting it. > > > > Could you please ask the author if we can strike the > > All rights reserved, and if not please remove the white > > space between them. > > > > Perhaps also a SPDX tag for this while we're potentially changing the area? I wont express an opionion on that, but when you mentioned this I went back and looked at the commit, and right below the above is an additional line: +.\ This program is free software I am not sure if that even makes since, it is not a program, it is a manual page, and I am also not sure on how that affects the following BSD 2 clause. I normally associated those words with the GPL. Which leads me to wonder, did this file have a GPL on it and it got "removed" but left a tiny residual behind? I also find many instances of this in our tree, so this may come from a copy and paste. IMHO that line should also die. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201901111925.x0BJP0Ac022634>