Date: Thu, 14 Jun 2018 18:46:20 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Hans Petter Selasky <hps@selasky.org> Cc: Matthew Macy <mmacy@freebsd.org>, Ryan Libby <rlibby@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, bde@freebsd.org Subject: Re: svn commit: r335094 - head/sys/ofed/drivers/infiniband/core Message-ID: <20180614182603.U1417@besplex.bde.org> In-Reply-To: <c14b6b39-22b3-cdb5-d387-829bad3509f3@selasky.org> References: <201806132330.w5DNUsrE043573@repo.freebsd.org> <CAHgpiFwQza_CEeu687s-HwnHPT%2BfcPk80nHkbU3Kn-aUM2AjHQ@mail.gmail.com> <CAPrugNq-dGjOhJ7PW5zniggowENW74P5ttCWH01U=AmXcj4gzA@mail.gmail.com> <c14b6b39-22b3-cdb5-d387-829bad3509f3@selasky.org>
index | next in thread | previous in thread | raw e-mail
On Thu, 14 Jun 2018, Hans Petter Selasky wrote: > On 06/14/18 02:03, Matthew Macy wrote: >> On Wed, Jun 13, 2018 at 4:47 PM, Ryan Libby <rlibby@freebsd.org> wrote: >>> On Wed, Jun 13, 2018 at 4:30 PM, Matt Macy <mmacy@freebsd.org> wrote: >>>> Author: mmacy >>>> Date: Wed Jun 13 23:30:54 2018 >>>> New Revision: 335094 >>>> URL: https://svnweb.freebsd.org/changeset/base/335094 >>>> >>>> Log: >>>> fix OFED build after r335053 >* ... > Please revert this patch and fix MKDEV() in: > compat/linuxkpi/common/include/linux/kdev_t.h > > Instead. > > The value returned by MKDEV() must be passable through MAJOR() and MINOR() to > restore the two arguments. Please make sure this is the case. Else the code > gets broken. Are these macros for conversion of host (FreeBSD) dev_t's or target (Linux) ones? If for the host, then I don't see any reason not to use the host APIs. If for the target, then they shouldn't be used with the host dev_t. If for a mixture, then the translations are very confusing, especially when they are the identity, and many more macros are needed to reduce the confusion. Brucehome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180614182603.U1417>