Date: Sun, 16 May 2021 00:44:54 +0200 From: Lutz Donnerhacke <lutz@donnerhacke.de> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, Lutz Donnerhacke <donner@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: effc8e57fbf0 - main - libalias: Style cleanup Message-ID: <20210515224454.GB21814@belenus.iks-jena.de> In-Reply-To: <67F972DE-A735-4537-8AFB-87E4E9832424@freebsd.org> References: <202105150701.14F717lf084359@gitrepo.freebsd.org> <YKAkAcYHXN7XMyoL@kib.kiev.ua> <20210515195812.GB17734@belenus.iks-jena.de> <YKArpyRTTAah4LSG@kib.kiev.ua> <20210515205133.GA19770@belenus.iks-jena.de> <YKA9jrWPkeCUgwPf@kib.kiev.ua> <20210515223634.GA21814@belenus.iks-jena.de> <67F972DE-A735-4537-8AFB-87E4E9832424@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 15, 2021 at 11:42:06PM +0100, Jessica Clarke wrote: > I think you two are talking past each other. kib@’s point is that some of the > changes made in this commit were style *changes* not style *fixes* (i.e. the > code was compliant before, you’ve just changed it from one acceptable > formatting to another), and that there were instances of significant style > violations *not* fixed (e.g. the assertion macro before variable declarations > pointed out). He is not talking about functional violations, only style ones. > However, in your defence, your original commit did not claim to fix *all* style > violations, only "most annoying style errors", though that doesn’t account for > unnecessary churn as seen with the blank lines at the starts of functions. You are right. Let's close this discussion.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210515224454.GB21814>