Date: Tue, 17 Apr 2001 14:13:59 -0700 (PDT) From: Matt Dillon <dillon@earth.backplane.com> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Alfred Perlstein <bright@wintelcom.net>, Kirk McKusick <mckusick@mckusick.com>, Julian Elischer <julian@elischer.org>, Rik van Riel <riel@conectiva.com.br>, freebsd-hackers@FreeBSD.ORG, David Xu <bsddiy@21cn.com> Subject: Re: vm balance Message-ID: <200104172113.f3HLDxP07733@earth.backplane.com> References: <27879.987541244@critter>
next in thread | previous in thread | raw e-mail | index | archive | help
:> reference to me. I'm not even sure why they bother to check v_id.
:> The vp reference from an nfsnode is a hard reference.
:>
:
:Well, if that's the case, yank all uses of v_id from the nfs code,
:I'll do the namecache and vnodes can be deleted to the joy of our users...
:
:--
:Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
:phk@FreeBSD.ORG | TCP/IP since RFC 956
If you can yank v_id out from the kern/vfs_cache code, I will make similar
fixes to the NFS code. I am not particularly interesting in returning
vnodes to the MALLOC pool myself, but I am interested in fixing the
two bugs I noticed when I ran over the code earlier today.
Actually one bug. The vput() turns out to be correct, I just looked at
the code again. However, the cache_lookup() call in nfs_vnops.c is
broken. Assuming no other fixes, the vpid load needs to occur before
the VOP_ACCESS call rather then after.
-Matt
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200104172113.f3HLDxP07733>