Date: Mon, 15 Nov 2021 14:11:22 +0100 From: Torsten Zuehlsdorff <freebsd@toco-domains.de> To: Matthias Fechner <mfechner@FreeBSD.org>, Po-Chuan Hsieh <sunpoet@freebsd.org>, bradleythughes@fastmail.fm Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 46ce086c7130 - main - Mk/Uses: default version for nodejs Message-ID: <d871cba3-7ad3-47ce-267e-b550e060f91e@toco-domains.de> In-Reply-To: <ddc9665b-5118-7292-8d54-4722459a6a37@FreeBSD.org> References: <202111120555.1AC5tGbw088641@gitrepo.freebsd.org> <CAMHz58R-TJKznK8NHNbKjAGjToXcg9OPYjWxWH2G0DvyQNc3Gg@mail.gmail.com> <ddc9665b-5118-7292-8d54-4722459a6a37@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15.11.21 09:16, Matthias Fechner wrote: > Am 14.11.2021 um 18:00 schrieb Po-Chuan Hsieh: >> Please revert the nodejs change. >> It is not approved. >> It should be committed after being accepted by all parties. >> As I mentioned in the review, I disagreed with the change of the >> default from www/node to www/node16. > > could you please let me know what is broken, then I will look into it? > > The modification has not only unbroken gitlab but also fixed many other > software packages (that are not part of ports) but do not work with node17. BTW: node16 does not compile for me so gitlab is still broken. Is this only me? o.O Best, Torsten
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d871cba3-7ad3-47ce-267e-b550e060f91e>