Date: Sat, 19 Oct 2002 15:52:54 +0300 From: Peter Pentchev <roam@ringlet.net> To: audit@FreeBSD.org Subject: Re: [CFR] 4.x-STABLE ftp client signedness patch Message-ID: <20021019125254.GD363@straylight.oblivion.bg> In-Reply-To: <20021017181225.GH369@straylight.oblivion.bg> References: <20021017181225.GH369@straylight.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, Oct 17, 2002 at 09:12:25PM +0300, Peter Pentchev wrote: > Hi, > > The "old" FTP client in -STABLE has a little problem when retrieving > files via HTTP: a variable that holds the read() return value is > unsigned, which leads to misinterpreted failures when the connection is > closed by the remote side and read() returns -1. > > Yes, I know it has never really been ftp(1)'s job to fetch via HTTP; > still, this is what a friend of mine has been using until today, when he > reported the failure and I tracked down the bug. I taught him about > fetch(1), but there is no reason for the bug to stay unfixed :) > > The trivial patch is attached; it only applies to -STABLE, because > -CURRENT uses lukemftp now. I took a look through the lukemftp source > with a quick grep for 'size_t' and 'unsigned', and there do not seem to > be any similar problems there. Just for the record, I just committed this to -STABLE. G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 Thit sentence is not self-referential because "thit" is not a word. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQE9sVWm7Ri2jRYZRVMRAiAuAJ9ln8G7xTvbwO0fKsOoxEPRAlRe1QCgqfaX Ha/GV5IBMhtaXfZqhZMm6iQ= =s+th -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021019125254.GD363>