Date: Tue, 18 Aug 2009 20:38:58 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Attilio Rao <attilio@freebsd.org> Cc: svn-src-head@freebsd.org, Sam Leffler <sam@errno.com>, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r196358 - in head: share/man/man9 sys/kern sys/sys Message-ID: <20090818183858.GB1794@garage.freebsd.pl> In-Reply-To: <3bbf2fe10908181106u159934b9ofc4c2a5e4793b692@mail.gmail.com> References: <200908181355.n7IDtmqT019165@svn.freebsd.org> <4A8AC814.2070804@errno.com> <3bbf2fe10908181106u159934b9ofc4c2a5e4793b692@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--LyciRD1jyfeSSjG0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 18, 2009 at 08:06:17PM +0200, Attilio Rao wrote: > 2009/8/18 Sam Leffler <sam@errno.com>: > > Pawel Jakub Dawidek wrote: > >> > >> Author: pjd > >> Date: Tue Aug 18 13:55:48 2009 > >> New Revision: 196358 > >> URL: http://svn.freebsd.org/changeset/base/196358 > >> > >> Log: > >> Remove unused taskqueue_find() function. > >> Reviewed by: dfr > >> Approved by: re (kib) > > > > I don't understand why this should be removed (let alone during a code > > freeze). I can think of several uses for this function including a ddb= cmd > > that takes a taskq name and dumps it's contents. The overhead of > > maintaining the global list appears minimal. >=20 > FWIW, I agree with Sam. The only use I could think of was exactly what Sam suggested - a DDB command and that was the only possible use I found. I decided to propose removal of this KPI, because nobody decided to use it for more than 9 years now and this is a good thing to remove unused code, no? I won't fight for keeping it removed, really. If after 9 years someone will find it useful I'm all for bringing it back. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --LyciRD1jyfeSSjG0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKivVCForvXbEpPzQRAoqJAJ4u8fVeJVh08zqneE0sYBzhgpl9AQCfcMQe QhRMxxmXyuFpva5xdJsNs98= =xyEE -----END PGP SIGNATURE----- --LyciRD1jyfeSSjG0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090818183858.GB1794>