Date: Fri, 25 Aug 2017 12:09:38 -0600 From: Warner Losh <imp@bsdimp.com> To: Matt Joras <matt.joras@gmail.com> Cc: "Conrad E. Meyer" <cem@freebsd.org>, Alan Somers <asomers@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r322893 - head/bin/dd Message-ID: <CANCZdfpNq33VwDRkiFH8daERuOCKai6nuvtY1JMw3CH-LFN6Jg@mail.gmail.com> In-Reply-To: <4b016f89-61c5-fc8a-a36a-aca8166c369e@gmail.com> References: <201708251531.v7PFVtoZ038242@repo.freebsd.org> <CAG6CVpU5rsrwU4EEkF3i5gvzSZRX3Q=K%2B8M-LMwk2cGP8hMSxw@mail.gmail.com> <4b016f89-61c5-fc8a-a36a-aca8166c369e@gmail.com>
index | next in thread | previous in thread | raw e-mail
On Fri, Aug 25, 2017 at 12:02 PM, Matt Joras <matt.joras@gmail.com> wrote: > On 08/25/2017 10:17, Conrad Meyer wrote: > > This change seems to break buildworld on MIPS: > > > > /home/cem/head.svn/bin/dd/args.c: In function 'f_bs': > > /home/cem/head.svn/bin/dd/args.c:188: warning: format '%zd' expects > > type 'signed size_t', but argument 3 has type 'long int' > > /home/cem/head.svn/bin/dd/args.c: In function 'f_cbs': > > /home/cem/head.svn/bin/dd/args.c:199: warning: format '%zd' expects > > type 'signed size_t', but argument 3 has type 'long int' > > /home/cem/head.svn/bin/dd/args.c: In function 'f_ibs': > > /home/cem/head.svn/bin/dd/args.c:245: warning: format '%zd' expects > > type 'signed size_t', but argument 3 has type 'long int' > > /home/cem/head.svn/bin/dd/args.c: In function 'f_obs': > > /home/cem/head.svn/bin/dd/args.c:266: warning: format '%zd' expects > > type 'signed size_t', but argument 3 has type 'long int' > > > > (Yes, it's odd that the SSIZE_MAX constant has 'long' type.) > > > SSIZE_MAX should have type long, since ssize_t is a long on mips (and > other arches besides i386 and arm). > > Re: the build failure, that's in the GCC C format string checking, so > perhaps it's more accurate to say this breaks the (in-tree) GCC build. > %zd is the right format specifier for ssize_t. I guess GCC's format > string checking is getting confused because SSIZE_MAX is a constant that > expands to type long. Perhaps casting to ssize_t would GCC happier, but > that looks rather wrong. > This is why it was cast in the first place due to issues with exact type. Maybe we should put the casts back for the printfs. Warnerhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpNq33VwDRkiFH8daERuOCKai6nuvtY1JMw3CH-LFN6Jg>