Date: Thu, 28 Jun 2007 13:57:50 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netatalk aarp.h ddp.h Message-ID: <20070628135639.Q37694@fledge.watson.org> In-Reply-To: <200706281254.l5SCswtj063484@repoman.freebsd.org> References: <200706281254.l5SCswtj063484@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 28 Jun 2007, Robert Watson wrote: > rwatson 2007-06-28 12:54:58 UTC > > FreeBSD src repository > > Modified files: > sys/netatalk aarp.h ddp.h > Log: > Mark wire data structures in netatalk as __packed so that they are > properly (un)padded on the arm platform. With this change, FreeBSD/arm > boxes are able to route AppleTalk properly. > > Submitted/tested by: Nathan Whitehorn <nathanw at uchicago dot edu> > Tested on: arm, i386, amd64 > Approved by: re (kensmith) We've now scattered __packed in a number of protocols, but I can't help but wonder if we shouldn't generally be doing a sweep of callers to mtod() to find all places where we cast wire data structures to C structures and checking padding across platforms. It would also be good to add more CTASSERT's about wire data structure sizes beside their definitions. Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070628135639.Q37694>