Date: Mon, 6 Jan 2003 08:22:33 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Nate Lawson <nate@root.org> Cc: Jake Burkholder <jake@FreeBSD.org>, <cvs-all@FreeBSD.org>, <cvs-committers@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/sab sab.c Message-ID: <20030106075621.M616-100000@gamplex.bde.org> In-Reply-To: <Pine.BSF.4.21.0301051210580.7893-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 5 Jan 2003, Nate Lawson wrote: > On Sat, 4 Jan 2003, Jake Burkholder wrote: > > Modified files: > > sys/dev/sab sab.c > > Log: > > Sync with zs. > > - Fix some bogosity with mixing unit numbers and channels, which would only > > work for one instance of the device. > > - Use a simpler scheme for input and output queueing. > > - Use db_alt_break. > > > > Revision Changes Path > > 1.8 +178 -238 src/sys/dev/sab/sab.c > > I've always wondered if you were supposed to deliver the char before > calling breakpoint(). Looks like you do this but it seemed like sio > didn't. What's the desired behavior? The escape sequence for the breakpoint shouldn't be delivered at all. sio seems to get this right for the final character in the sequence (using "goto cont;") but not for the previous characters (it sets the state variables for them but falls through to handle them normally). If the final character is delivered, then whether it is delivered before or after calling breakpoint() doesn't matter much. Only the internals of the interrupt handler and the state machine could normally tell the difference. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030106075621.M616-100000>