Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 2 Jun 2018 16:53:01 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        Eitan Adler <eadler@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r334540 - head/usr.bin/top
Message-ID:  <201806022353.w52Nr1LA088636@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201806022140.w52LejjF005616@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ]
> Author: eadler
> Date: Sat Jun  2 21:40:45 2018
> New Revision: 334540
> URL: https://svnweb.freebsd.org/changeset/base/334540
> 
> Log:
>   top(1): cleanup memory allocation and warnings
>   
>   - Prefer calloc over malloc. This is more predicable and we're not in a
>   performance sensitive context. [1]
>   - Remove bogus comment (obsolete from prior commit). [2]
>   - Remove void casts and type casts of NULL
>   - Remove redundant declaration of 'quit'
>   - Add additional const
>   
>   Reported by:	kib [1], vangyzen [2]
> 
> Modified:
>   head/usr.bin/top/display.c
>   head/usr.bin/top/machine.c
>   head/usr.bin/top/screen.c
>   head/usr.bin/top/screen.h
>   head/usr.bin/top/utils.c
...

> 
> Modified: head/usr.bin/top/screen.c
> ==============================================================================
> --- head/usr.bin/top/screen.c	Sat Jun  2 21:16:20 2018	(r334539)
> +++ head/usr.bin/top/screen.c	Sat Jun  2 21:40:45 2018	(r334540)
> @@ -3,7 +3,7 @@
>   *  Version 3
>   *
>   *  This program may be freely redistributed,
> - *  but this entire comment MUST remain intact.
> + *  but this entire ceomment MUST remain intact.

I know you have already fixed this spelling error,
but I believe there are some other commits that actually
removed either this string, or some part of "this entire"
comment that is to "remain intact".

Regards,
-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201806022353.w52Nr1LA088636>