Date: Mon, 9 Sep 2002 17:56:26 -0700 (PDT) From: Don Lewis <dl-freebsd@catspoiler.org> To: rwatson@FreeBSD.org Cc: current@FreeBSD.org, jeff@FreeBSD.org Subject: Re: vnode lock assertion problem in nfs_link() Message-ID: <200209100056.g8A0uQwr093581@gw.catspoiler.org> In-Reply-To: <Pine.NEB.3.96L.1020909200649.4317A-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9 Sep, Robert Watson wrote: > On Mon, 9 Sep 2002, Don Lewis wrote: >> I think we can probably just lock and unlock vp around the call to >> VOP_FSYNC() ... > > What I'd actually like to do is lock vp on going in to the VOP. I need to > grab the lock in the link() code anyway to do the MAC check. UFS and > others all immediately lock the vnode on entry anyway... That sounds reasonable. It looks like ufs and ext2fs are currently doing the locking and nfs and coda aren't. The only other filesystem that implements the link method is unionfs, which conditionally does the lock only in certain cases and does some complex lock manipulations that I don't fully understand. BTW, I noticed that a number of filesystems have reimplemented vop_eopnotsupp() and called it foofs_link(). To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200209100056.g8A0uQwr093581>