Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 03 Mar 2010 21:04:11 -0800
From:      Maxim Sobolev <sobomax@FreeBSD.org>
To:        Warner Losh <imp@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn: head/sbin/newfs
Message-ID:  <4B8F3F4B.7020002@FreeBSD.org>
In-Reply-To: <201003032153.o23LrQwl076528@svn.freebsd.org>
References:  <201003032153.o23LrQwl076528@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh wrote:
> Author: imp
> Date: Wed Mar  3 21:53:25 2010
> New Revision: 204672
> URL: http://svn.freebsd.org/changeset/base/204672
> 
> Log:
>   Cast these to intmax_t before printing to fix build bustage.  Better
>   solutions welcome.

Thanks for a quick fix and sorry for the breakage. IMHO you fix's fine, 
there is no real reason to use 64-bit quantity anyway, it's just because 
expand_number(3) interface is not very well designed and forces anyone 
using it stick with that data type. So downsizing from 64-bit to 32-bit 
on platforms where intmax_t is 32-bit only (if any) should not be an 
issue in real life.

-Maxim



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B8F3F4B.7020002>