Date: Sat, 20 Sep 2025 23:41:46 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 87a7b35f04b6 - main - bsdinstall: fix vfs.zfs.vdev.min_auto_ashift oid Message-ID: <CAFDf7UL7%2B-erWjmAcRnBM==DUMTt%2BwN=DFM5=u2oigQno3gS_w@mail.gmail.com> In-Reply-To: <202509191603.58JG3EF6037438@gitrepo.freebsd.org> References: <202509191603.58JG3EF6037438@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Hello! I've just upgraded to a recent main and on boot i see: `sysctl: unknown oid 'vfs.zfs.min_auto_ashift' at line 9` I remember this line in /etc/sysctl.conf for years: ``` # # This file is read when going to multi-user and its contents piped thru # ``sysctl'' to adjust kernel values. ``man 5 sysctl.conf'' for details. # # Uncomment this to prevent users from seeing information about processes that # are being run under another UID. #security.bsd.see_other_uids=0 vfs.zfs.min_auto_ashift=12 ``` Do we need to fix it from vfs.zfs.min_auto_ashift -> vfs.zfs.vdev.min_auto_ashift on /etc/sysctl.conf? Cheers, Ed Maste <emaste@freebsd.org> escreveu (sexta, 19/09/2025 à(s) 17:03): > The branch main has been updated by emaste: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=87a7b35f04b60956e9aa192680ae80773ec38f14 > > commit 87a7b35f04b60956e9aa192680ae80773ec38f14 > Author: Siva Mahadevan <me@svmhdvn.name> > AuthorDate: 2025-07-15 16:45:24 +0000 > Commit: Ed Maste <emaste@FreeBSD.org> > CommitDate: 2025-09-19 16:02:57 +0000 > > bsdinstall: fix vfs.zfs.vdev.min_auto_ashift oid > > Signed-off-by: Siva Mahadevan <me@svmhdvn.name> > PR: 266374 > Pull request: https://github.com/freebsd/freebsd-src/pull/1851 > Reviewed by: emaste > Sponsored by: The FreeBSD Foundation > --- > usr.sbin/bsdinstall/scripts/zfsboot | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/usr.sbin/bsdinstall/scripts/zfsboot > b/usr.sbin/bsdinstall/scripts/zfsboot > index aa05faa7d3dd..5fbf56ea59ac 100755 > --- a/usr.sbin/bsdinstall/scripts/zfsboot > +++ b/usr.sbin/bsdinstall/scripts/zfsboot > @@ -69,7 +69,7 @@ f_include $BSDCFG_SHARE/variable.subr > : ${ZFSBOOT_VDEV_TYPE:=stripe} > > # > -# Should we use sysctl(8) vfs.zfs.min_auto_ashift=12 to force 4K sectors? > +# Should we use sysctl(8) vfs.zfs.vdev.min_auto_ashift=12 to force 4K > sectors? > # > : ${ZFSBOOT_FORCE_4K_SECTORS=1} > > @@ -221,7 +221,7 @@ PRINTF_CONF="printf '%s=\"%%s\"\\\n' %s >> \"%s\"" > PRINTF_FSTAB='printf "$FSTAB_FMT" "%s" "%s" "%s" "%s" "%s" "%s" >> "%s"' > SHELL_TRUNCATE=':> "%s"' > SWAP_GMIRROR_LABEL='gmirror label swap %s' > -SYSCTL_ZFS_MIN_ASHIFT_12='sysctl vfs.zfs.min_auto_ashift=12' > +SYSCTL_ZFS_MIN_ASHIFT_12='sysctl vfs.zfs.vdev.min_auto_ashift=12' > UMOUNT='umount "%s"' > ZFS_CREATE_WITH_OPTIONS='zfs create %s "%s"' > ZFS_MOUNT='zfs mount "%s"' > @@ -255,7 +255,7 @@ msg_encrypt_disks="Encrypt Disks?" > msg_encrypt_disks_help="Use geli(8) to encrypt all data partitions" > msg_error="Error" > msg_force_4k_sectors="Force 4K Sectors?" > -msg_force_4k_sectors_help="Align partitions to 4K sector boundries and > set vfs.zfs.min_auto_ashift=12" > +msg_force_4k_sectors_help="Align partitions to 4K sector boundries and > set vfs.zfs.vdev.min_auto_ashift=12" > msg_freebsd_installer="$OSNAME Installer" > msg_geli_password="Enter a strong passphrase, used to protect your > encryption keys. You will be required to enter this passphrase each time > the system is booted" > msg_geli_setup="Initializing encryption on selected disks,\n this will > take several seconds per disk" > @@ -1099,7 +1099,7 @@ zfs_create_boot() > # > f_dprintf "$funcname: Preparing disk partitions for ZFS pool..." > > - # Force 4K sectors using vfs.zfs.min_auto_ashift=12 > + # Force 4K sectors using vfs.zfs.vdev.min_auto_ashift=12 > if [ "$ZFSBOOT_FORCE_4K_SECTORS" ]; then > f_dprintf "$funcname: With 4K sectors..." > f_eval_catch $funcname sysctl "$SYSCTL_ZFS_MIN_ASHIFT_12" \ > @@ -1382,7 +1382,7 @@ zfs_create_boot() > > if [ "$ZFSBOOT_FORCE_4K_SECTORS" ]; then > f_eval_catch $funcname echo "$ECHO_APPEND" \ > - 'vfs.zfs.min_auto_ashift=12' \ > + 'vfs.zfs.vdev.min_auto_ashift=12' \ > $BSDINSTALL_TMPETC/sysctl.conf.zfs || return $FAILURE > fi > > > -- Nuno Teixeira FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org [-- Attachment #2 --] <div dir="ltr"><div>Hello!</div><div><br></div><div>I've just upgraded to a recent main and on boot i see:<br><br>`sysctl: unknown oid 'vfs.zfs.min_auto_ashift' at line 9`<br><br></div><div>I remember this line in /etc/sysctl.conf for years:<br><br>```</div><div>#<br># This file is read when going to multi-user and its contents piped thru<br># ``sysctl'' to adjust kernel values. ``man 5 sysctl.conf'' for details.<br>#<br><br># Uncomment this to prevent users from seeing information about processes that<br># are being run under another UID.<br>#security.bsd.see_other_uids=0<br>vfs.zfs.min_auto_ashift=12<br>```<br></div><div>Do we need to fix it from <span class="gmail-il"><span class="gmail-il"><span class="gmail-il"><span class="gmail-il">vfs</span></span></span></span>.<span class="gmail-il"><span class="gmail-il"><span class="gmail-il"><span class="gmail-il">zfs</span></span></span></span>.<span class="gmail-il"><span class="gmail-il"><span class="gmail-il"><span class="gmail-il">min_auto_ashift -> </span></span></span></span><span class="gmail-il"><span class="gmail-il"><span class="gmail-il"><span class="gmail-il">vfs</span></span></span></span>.<span class="gmail-il"><span class="gmail-il"><span class="gmail-il"><span class="gmail-il">zfs</span></span></span></span>.vdev.<span class="gmail-il"><span class="gmail-il"><span class="gmail-il"><span class="gmail-il">min_auto_ashift on /etc/sysctl.conf?<br><br></span></span></span></span></div><div>Cheers,</div></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">Ed Maste <<a href="mailto:emaste@freebsd.org">emaste@freebsd.org</a>> escreveu (sexta, 19/09/2025 à(s) 17:03):<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by emaste:<br> <br> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=87a7b35f04b60956e9aa192680ae80773ec38f14" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=87a7b35f04b60956e9aa192680ae80773ec38f14</a><br>; <br> commit 87a7b35f04b60956e9aa192680ae80773ec38f14<br> Author: Siva Mahadevan <<a href="mailto:me@svmhdvn.name" target="_blank">me@svmhdvn.name</a>><br> AuthorDate: 2025-07-15 16:45:24 +0000<br> Commit: Ed Maste <emaste@FreeBSD.org><br> CommitDate: 2025-09-19 16:02:57 +0000<br> <br> bsdinstall: fix vfs.zfs.vdev.min_auto_ashift oid<br> <br> Signed-off-by: Siva Mahadevan <<a href="mailto:me@svmhdvn.name" target="_blank">me@svmhdvn.name</a>><br> PR: 266374<br> Pull request: <a href="https://github.com/freebsd/freebsd-src/pull/1851" rel="noreferrer" target="_blank">https://github.com/freebsd/freebsd-src/pull/1851</a><br>; Reviewed by: emaste<br> Sponsored by: The FreeBSD Foundation<br> ---<br> usr.sbin/bsdinstall/scripts/zfsboot | 10 +++++-----<br> 1 file changed, 5 insertions(+), 5 deletions(-)<br> <br> diff --git a/usr.sbin/bsdinstall/scripts/zfsboot b/usr.sbin/bsdinstall/scripts/zfsboot<br> index aa05faa7d3dd..5fbf56ea59ac 100755<br> --- a/usr.sbin/bsdinstall/scripts/zfsboot<br> +++ b/usr.sbin/bsdinstall/scripts/zfsboot<br> @@ -69,7 +69,7 @@ f_include $BSDCFG_SHARE/variable.subr<br> : ${ZFSBOOT_VDEV_TYPE:=stripe}<br> <br> #<br> -# Should we use sysctl(8) vfs.zfs.min_auto_ashift=12 to force 4K sectors?<br> +# Should we use sysctl(8) vfs.zfs.vdev.min_auto_ashift=12 to force 4K sectors?<br> #<br> : ${ZFSBOOT_FORCE_4K_SECTORS=1}<br> <br> @@ -221,7 +221,7 @@ PRINTF_CONF="printf '%s=\"%%s\"\\\n' %s >> \"%s\""<br> PRINTF_FSTAB='printf "$FSTAB_FMT" "%s" "%s" "%s" "%s" "%s" "%s" >> "%s"'<br> SHELL_TRUNCATE=':> "%s"'<br> SWAP_GMIRROR_LABEL='gmirror label swap %s'<br> -SYSCTL_ZFS_MIN_ASHIFT_12='sysctl vfs.zfs.min_auto_ashift=12'<br> +SYSCTL_ZFS_MIN_ASHIFT_12='sysctl vfs.zfs.vdev.min_auto_ashift=12'<br> UMOUNT='umount "%s"'<br> ZFS_CREATE_WITH_OPTIONS='zfs create %s "%s"'<br> ZFS_MOUNT='zfs mount "%s"'<br> @@ -255,7 +255,7 @@ msg_encrypt_disks="Encrypt Disks?"<br> msg_encrypt_disks_help="Use geli(8) to encrypt all data partitions"<br> msg_error="Error"<br> msg_force_4k_sectors="Force 4K Sectors?"<br> -msg_force_4k_sectors_help="Align partitions to 4K sector boundries and set vfs.zfs.min_auto_ashift=12"<br> +msg_force_4k_sectors_help="Align partitions to 4K sector boundries and set vfs.zfs.vdev.min_auto_ashift=12"<br> msg_freebsd_installer="$OSNAME Installer"<br> msg_geli_password="Enter a strong passphrase, used to protect your encryption keys. You will be required to enter this passphrase each time the system is booted"<br> msg_geli_setup="Initializing encryption on selected disks,\n this will take several seconds per disk"<br> @@ -1099,7 +1099,7 @@ zfs_create_boot()<br> #<br> f_dprintf "$funcname: Preparing disk partitions for ZFS pool..."<br> <br> - # Force 4K sectors using vfs.zfs.min_auto_ashift=12<br> + # Force 4K sectors using vfs.zfs.vdev.min_auto_ashift=12<br> if [ "$ZFSBOOT_FORCE_4K_SECTORS" ]; then<br> f_dprintf "$funcname: With 4K sectors..."<br> f_eval_catch $funcname sysctl "$SYSCTL_ZFS_MIN_ASHIFT_12" \<br> @@ -1382,7 +1382,7 @@ zfs_create_boot()<br> <br> if [ "$ZFSBOOT_FORCE_4K_SECTORS" ]; then<br> f_eval_catch $funcname echo "$ECHO_APPEND" \<br> - 'vfs.zfs.min_auto_ashift=12' \<br> + 'vfs.zfs.vdev.min_auto_ashift=12' \<br> $BSDINSTALL_TMPETC/sysctl.conf.zfs || return $FAILURE<br> fi<br> <br> <br> </blockquote></div><div><br clear="all"></div><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><font color="#888888">Nuno Teixeira</font></div><div><div><font color="#888888"> FreeBSD UNIX: <eduardo@FreeBSD.org> Web: <a href="https://FreeBSD.org" rel="noreferrer" target="_blank">https://FreeBSD.org</a><br></font></div></div></div></div>;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UL7%2B-erWjmAcRnBM==DUMTt%2BwN=DFM5=u2oigQno3gS_w>