Date: Sat, 29 Oct 2016 14:16:20 -0500 From: Eric van Gyzen <vangyzen@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, David Bright <dab@FreeBSD.org> Subject: Re: svn commit: r306577 - head/sys/netinet Message-ID: <0952149f-97f0-23e9-e39c-28eef3ddeb00@FreeBSD.org> In-Reply-To: <661a719c-39c8-7a3b-e300-9184475ac2c7@selasky.org> References: <201610020142.u921gjsJ016528@repo.freebsd.org> <661a719c-39c8-7a3b-e300-9184475ac2c7@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/29/2016 11:50, Hans Petter Selasky wrote:
> On 10/02/16 03:42, Eric van Gyzen wrote:
>> + if (callout_reset(&ia->ia_garp_timer, (1 << ia->ia_garp_count) * hz,
>> + garp_rexmit, ia) == 0) {
>> + ifa_ref(ifa);
>> + }
>
> Hi,
>
> Be careful when you MFC this, because the return values of callout_reset() and
> callout_stop() are not the same in FreeBSD-9, -10 and 11/12.
Thanks for your keen eye, Hans. Indeed, the submitter (David Bright) discovered
this The Hard Way when porting this forward from 10 to head. Luckily, though,
that means we already have a version of this patch for 10.
Thanks again,
Eric (and David)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0952149f-97f0-23e9-e39c-28eef3ddeb00>