Date: Wed, 20 Apr 2016 09:35:21 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: Pedro Giffuni <pfg@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r298320 - head/sbin/sunlabel Message-ID: <CAOfEmZgSq8zASMaQ0ALd8z-aWoq8OCxWK3J44yM%2B5Xf8Y6Efag@mail.gmail.com> In-Reply-To: <81a0edfd-67cf-5049-a4d7-f6b5e517f529@FreeBSD.org> References: <201604200105.u3K15sCP021936@repo.freebsd.org> <81a0edfd-67cf-5049-a4d7-f6b5e517f529@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2016-04-20 9:24 GMT+08:00 Pedro Giffuni <pfg@freebsd.org>: > > > On 04/19/16 20:05, Marcelo Araujo wrote: > >> Author: araujo >> Date: Wed Apr 20 01:05:54 2016 >> New Revision: 298320 >> URL: https://svnweb.freebsd.org/changeset/base/298320 >> >> Log: >> Use nitems() from sys/param.h. >> >> MFC after: 2 weeks. >> >> Modified: >> head/sbin/sunlabel/sunlabel.c >> >> Modified: head/sbin/sunlabel/sunlabel.c >> >> ============================================================================== >> --- head/sbin/sunlabel/sunlabel.c Wed Apr 20 01:03:06 2016 >> (r298319) >> +++ head/sbin/sunlabel/sunlabel.c Wed Apr 20 01:05:54 2016 >> (r298320) >> @@ -903,7 +903,7 @@ tagname(unsigned int tag) >> struct tags *tp; >> >> for (i = 0, tp = knowntags; >> - i < sizeof(knowntags) / sizeof(struct tags); >> + i < nitems(knowntags); >> i++, tp++) >> if (tp->id == tag) >> return (tp->name); >> > > Please re-indent lines like this, the complete "for" fits in one line. > (same for the others) > > Pedro. > > > @@ -921,7 +921,7 @@ flagname(unsigned int flag) >> struct tags *tp; >> >> for (i = 0, tp = knownflags; >> - i < sizeof(knownflags) / sizeof(struct tags); >> + i < nitems(knownflags); >> i++, tp++) >> if (tp->id == flag) >> return (tp->name); >> @@ -940,7 +940,7 @@ parse_tag(struct sun_disklabel *sl, int >> unsigned long l; >> >> for (i = 0, tp = knowntags; >> - i < sizeof(knowntags) / sizeof(struct tags); >> + i < nitems(knowntags); >> i++, tp++) >> if (strcmp(tp->name, tag) == 0) { >> sl->sl_vtoc_map[part].svtoc_tag = >> (uint16_t)tp->id; >> @@ -965,7 +965,7 @@ parse_flag(struct sun_disklabel *sl, int >> unsigned long l; >> >> for (i = 0, tp = knownflags; >> - i < sizeof(knownflags) / sizeof(struct tags); >> + i < nitems(knownflags); >> i++, tp++) >> if (strcmp(tp->name, flag) == 0) { >> sl->sl_vtoc_map[part].svtoc_flag = >> (uint16_t)tp->id; >> >> Done! Thanks! -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^ Power To Server. .\. /_)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZgSq8zASMaQ0ALd8z-aWoq8OCxWK3J44yM%2B5Xf8Y6Efag>