Date: Mon, 22 Apr 2013 23:53:44 +0200 From: "O. Hartmann" <ohartman@zedat.fu-berlin.de> To: Ed Schouten <ed@80386.nl> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: CURRENT: /usr/src/sbin/newfs_nandfs/newfs_nandfs.c:89:18: error: no previous extern declaration for non-static variable Message-ID: <1366667624.1416.12.camel@thor.walstatt.dyndns.org> In-Reply-To: <CAJOYFBBqkabQwcK_JJ3_pVtEhC-%2BdEte8rn9MwOyi_kMm7Qufg@mail.gmail.com> References: <1366574922.38339.59.camel@thor.walstatt.dyndns.org> <CAJOYFBBqkabQwcK_JJ3_pVtEhC-%2BdEte8rn9MwOyi_kMm7Qufg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-MlYMvKyDFXkz6AwnCGTc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Mon, 2013-04-22 at 00:09 +0200, Ed Schouten wrote: > Hi, >=20 > 2013/4/21 O. Hartmann <ohartman@zedat.fu-berlin.de>: > > /usr/src/sbin/newfs_nandfs/newfs_nandfs.c:83:18: error: no previous > > extern declaration for non-static variable > > 'user_files' [-Werror,-Wmissing-variable-declarations] > > struct file_info user_files[] =3D > > ^ >=20 > The following patch should fix this: >=20 > http://80386.nl/pub/nandfs-warns-6.txt >=20 > As of a couple of days ago, WARNS=3D6 requires that global variables > either have an external declaration or are marked static. As > newfs_nandfs only consists of a single C file, we can easily mark > these variables static. In this specific case it allowed the compiler > to find another peculiarity in the code, namely that the > seg_segsum_size variable is unused. >=20 > I'll commit this patch after I've done some testing. >=20 > Thanks, > -- > Ed Schouten <ed@80386.nl> Thank you very much. Oliver --=-MlYMvKyDFXkz6AwnCGTc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAABAgAGBQJRdbFoAAoJEOgBcD7A/5N8IFkIALDnCm7wNFBn7AJvMT6gLtaV FEfEnliIEy/sttIqZOdQS0t04+RZe5I8pIYMlQTPSdmVFU4mPUbFwY51T894Wd77 r/Vl64dPFqhXwek4/mKbLh3ibHTgIUAShU9iypWN/3cRY9mslqBUpuI6neSpJUh8 kBhzCHymJQAxb7ySXEBsczlDsX9HPUzYYcNDoXX0g1BLJU0fi4tLOlhG/tfgDG9n fkwfTNNDbViWGh6IEcUwctS8yx1kpeNFKcBaPKDDiR/u/lM6+XsJe76w/JkxcIOZ PVx1DNiB/ndaoWsPBAAyfhyr49fLYmXEE2O2Xbxj1GGleCjOQdd0recDsznTHXA= =hd2M -----END PGP SIGNATURE----- --=-MlYMvKyDFXkz6AwnCGTc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1366667624.1416.12.camel>