Date: Sat, 12 Dec 2020 17:33:06 +0000 From: Rick Macklem <rmacklem@uoguelph.ca> To: Konstantin Belousov <kostikbel@gmail.com> Cc: J David <j.david.lists@gmail.com>, "freebsd-fs@freebsd.org" <freebsd-fs@freebsd.org> Subject: Re: Major issues with nfsv4 Message-ID: <YQXPR0101MB0968C7629D57CA21319E50C2DDC90@YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM> In-Reply-To: <X9Q9GAhNHbXGbKy7@kib.kiev.ua> References: <CABXB=RRB2nUk0pPDisBQPdicUA3ooHpg8QvBwjG_nFU4cHvCYw@mail.gmail.com> <YQXPR0101MB096849ADF24051F7479E565CDDCA0@YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM> <CABXB=RSyN%2Bo2yXcpmYw8sCSUUDhN-w28Vu9v_cCWa-2=pLZmHg@mail.gmail.com> <YQXPR0101MB09680D155B6D685442B5E25EDDCA0@YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM> <CABXB=RSSE=yOwgOXsnbEYPqiWk5K5NfzLY=D%2BN9mXdVn%2B--qLQ@mail.gmail.com> <YQXPR0101MB0968B17010B3B36C8C41FDE1DDC90@YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM>, <X9Q9GAhNHbXGbKy7@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Konstantin Belousov wrote: [stuff snipped] >Nullfs vnodes keep a reference on the lower vnode. When nullfs vnode >caching is enabled, nullfs vnodes survive after a vfs syscall is finished. > >NFSv4 mount automatically sets flag MNTK_NULL_NOCACHE that disables nullfs >vnode cache. Thanks Kostik, I see that. (And I recall discussions about disabling the nullfs caching.) Now, if I understand it correctly, if vrele() is called with the vnode shared locked, then VOP_INACTIVE() won't be called. --> It is VOP_INACTIVE()/VOP_RECLAIM() in the NFSv4 client that does the closes. Normally the NFS client calls vput() when the vnode is locked, but is there a case where nullfs might cause vrele() to be called on the lower vp when it is shared locked? (Delaying closes until VOP_RECLAIM() would cause problems, I think?) Note that, until we see the "nfsstat -c -E" we won't know if lots of opens are an issue anyhow. Thanks for the help, rick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YQXPR0101MB0968C7629D57CA21319E50C2DDC90>