Date: Wed, 12 Nov 1997 16:18:14 +0100 (CET) From: frf@xocolatl.com To: FreeBSD-gnats-submit@FreeBSD.ORG Subject: i386/5019: Noisey debugging code in sb_dsp.c Message-ID: <199711121518.QAA00772@crux.tesco-stores.cz> Resent-Message-ID: <199711121630.IAA15385@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 5019
>Category: i386
>Synopsis: Noisey debugging code in sb_dsp.c
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Nov 12 08:30:02 PST 1997
>Last-Modified:
>Originator: frf
>Organization:
>Release: FreeBSD 3.0-CURRENT i386
>Environment:
3.0-CURRENT FreeBSD 3.0-CURRENT #3: Mon Nov 10 22:03:10 CET 1997
>Description:
Someone left their debugging printf's in /sys/i386/isa/sound/sb_dsp.c
>How-To-Repeat:
Build a kernel with SBPro support and play some music.
Watch your logfiles fill-up.
Nov 9 21:03:14 crux /kernel: dsp_speed 8000
Nov 9 21:03:14 crux /kernel: dsp_speed done 8000
Nov 9 21:03:18 crux /kernel: dsp_speed 8000
Nov 9 21:03:18 crux /kernel: dsp_speed done 8000
Nov 10 15:29:45 crux /kernel: dsp_speed 8000
Nov 10 15:29:45 crux /kernel: dsp_speed done 8000
Nov 10 15:29:45 crux /kernel: dsp_speed 44100
Nov 10 15:29:45 crux /kernel: dsp_speed done 43478
Nov 10 15:29:45 crux /kernel: dsp_speed 44100
Nov 10 15:29:45 crux /kernel: dsp_speed done 43478
Nov 10 15:30:48 crux /kernel: dsp_speed 8000
Nov 10 15:30:48 crux /kernel: dsp_speed done 8000
Nov 10 15:30:48 crux /kernel: dsp_speed 43478
Nov 10 15:30:49 crux /kernel: dsp_speed done 43478
>Fix:
--cut
--- /sys/i386/isa/sound/sb_dsp.c Fri Oct 31 18:25:05 1997
+++ sys/i386/isa/sound/sb_dsp.c Wed Nov 12 15:45:38 1997
@@ -231,7 +231,9 @@
u_long flags;
int max_speed = 44100;
-printf("dsp_speed %d\n", speed); /* XXX lr 970601 */
+#ifdef DSP_DEBUG
+ printf("dsp_speed %d\n", speed); /* XXX lr 970601 */
+#endif
if (speed < 4000)
speed = 4000;
@@ -310,7 +312,9 @@
speed /= 2;
dsp_current_speed = speed;
-printf("dsp_speed done %d\n", speed);
+#ifdef DSP_DEBUG
+ printf("dsp_speed done %d\n", speed);
+#endif
return speed;
}
--cut
or just delete the offending lines
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199711121518.QAA00772>