Date: Wed, 8 Jun 2016 22:21:36 -0400 From: Warner Losh <wlosh@bsdimp.com> To: Emmanuel Vadot <manu@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r301714 - head/sys/boot/efi/libefi Message-ID: <90D3441D-D130-4D00-A12D-F4D3B81E606B@bsdimp.com> In-Reply-To: <201606090202.u5922pwl024436@repo.freebsd.org> References: <201606090202.u5922pwl024436@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jun 8, 2016, at 10:02 PM, Emmanuel Vadot <manu@FreeBSD.org> wrote: > > Author: manu > Date: Thu Jun 9 02:02:50 2016 > New Revision: 301714 > URL: https://svnweb.freebsd.org/changeset/base/301714 > > Log: > Print a message when the efi disk isn't a logical partition. Why on earth would you do that? This will print a message, one per full disk, and our systems have 36 disks in them… Please consider backing this out... Warner > Approved by: andrew (mentor) > Differential Revision: https://reviews.freebsd.org/D6782 > > Modified: > head/sys/boot/efi/libefi/efipart.c > > Modified: head/sys/boot/efi/libefi/efipart.c > ============================================================================== > --- head/sys/boot/efi/libefi/efipart.c Thu Jun 9 01:50:43 2016 (r301713) > +++ head/sys/boot/efi/libefi/efipart.c Thu Jun 9 02:02:50 2016 (r301714) > @@ -119,8 +119,11 @@ efipart_init(void) > (void**)&blkio); > if (EFI_ERROR(status)) > continue; > - if (!blkio->Media->LogicalPartition) > + if (!blkio->Media->LogicalPartition) { > + printf("%s%d isn't a logical partition, skipping\n", > + efipart_dev.dv_name, n); > continue; > + } > > /* > * If we come across a logical partition of subtype CDROM >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?90D3441D-D130-4D00-A12D-F4D3B81E606B>