Date: Thu, 3 Jun 2021 12:11:57 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Torsten Zuehlsdorff <freebsd@toco-domains.de> Cc: Gerald Pfeifer <gerald@pfeifer.com>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: Replacing USE_GCC=any and the danfe@ filter (was: svn commit: r568012 - head/net/tightvnc) Message-ID: <20210603101157.noqag2ace5pcz6pu@aching.in.mat.cc> In-Reply-To: <64998e65-5200-ba36-eb61-f54b26a6e2a8@toco-domains.de> References: <f7316636-5fd2-cfd1-7661-3044fd782587@pfeifer.com> <20210603063235.676vy42y56fzvuu5@aching.in.mat.cc> <64998e65-5200-ba36-eb61-f54b26a6e2a8@toco-domains.de>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, Jun 03, 2021 at 11:50:54AM +0200, Torsten Zuehlsdorff wrote: > > > On 03.06.21 08:32, Mathieu Arnold wrote: > > On Thu, Jun 03, 2021 at 12:22:47AM +0200, Gerald Pfeifer wrote: > > > On Sun, 30 May 2021, Mathieu Arnold wrote: > > > > Thank you for working on this. > > > > > > So, I was just ready to commit the next step and prepared a nice git > > > style commit message: > > > > > > Replace USE_GCC=any with USE_GCC=yes > > > USE_GCC=any has been equivalent to USE_GCC=yes in most cases (such > > > as i386 and amd64 since 12.x and depending on configuration 11.x, > > > most newer installations on other platforms, and 13.x across the > > > board). > > > Since commit 96c17633d90386b5bcf8 Mk/bsd.gcc.mk ... > > > > > > Alas, the danfe@ filter struck: > > > > > > remote: Resolving deltas: 100% (111/111), completed with 111 local objects. > > > remote: > > > remote: ================================================================ > > > remote: First line does not start with the regular > > > remote: category/port: subject > > > remote: ================================================================ > > > > > > What now? > > > > > > Neither "*/*: Replace USE_GCC=any..." in the subject nor a couple dozen > > > individual commits strike me as desirable. > > > > *: Replace... works just fine. > > This seems to be a transcription of "It works around a rule which has its > purpose but should not be enforced 100% of the time". Well, no, the subject of all commits has to have a "discriminator" to tell people scanning commits what a commit is about. Having '*:' or '*/*:' for commits that span many ports is also fine, it does not defeats the rule, it acts as the discriminator saying that it's not about a specific port, but a change, like a framework sweep. -- Mathieu Arnold [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmC4quhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgKw/Q/9EekEaj9mlkYv+OUTCUC5A4MzIk4k7Tb1WpEqaXTaFCWnTM9JCyxEpfFl PIKGBDVYejLYxqMs8/2zAcy5mtoJEJmyVGxgMiP27wE+m3peDjzHlJk74Bxgenlr wzWJqPVxzMifY8yalFvJ3v+xQ8CuNaUrU/Mht7Vrnki217ZgCG1jbr0L7vNb82T9 97IRKp91yaJdhx+ULYD3mmQ7e71wfGSPJTN+t/nZd0g/nAckjHF0YOOcTk+lSZcp nvQokKdPeh7htjr/CT2T96DLgF1tweVZfJRVS7Gu84sMioLBs4NFz9nD367Q09Fb j5wiTqRYaes+GafSkj5tGER3kNZ2OWkKmGPqk0cvMk/qA2Tt1nfwqfO7qYU7Gx+j JS81lpDKhBKeZkD0CHFykrxD27LCwD/tSPQIj43NJXaaVMvbIQRgl/ET1Q5ZPbAw bkzkDCS4aOJY61F1YP44tnFHPLwhTTchc++OUcg0h+PEWV4ojMiWaj2oIc5LoRzV 68kv24kf9GsBX3Dw2jyZDE0IMt7HKgE3EM/hzZswePLsouJLv82i7ikMdtiO1fvT Y5Rn15I5mYc0zdp5VqJ+eYsvoZMwxmHsZ0UeBxWvPkNwcIvm83HaIArkwdGFBVyv CqjXnfR4KWgTPnJ3KMrOCTO9418XQA91f5qovPK+JjTwzenPYnU= =d+lv -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210603101157.noqag2ace5pcz6pu>