Date: Sat, 11 May 2002 02:37:43 +0100 From: Brian Somers <brian@Awfulhak.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Brian Somers <brian@Awfulhak.org>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Joerg Wunsch <joerg@FreeBSD.org> Subject: Re: cvs commit: src/sys/isa fd.c fdreg.h Message-ID: <200205110137.g4B1binA007822@hak.lan.Awfulhak.org> In-Reply-To: Message from John Baldwin <jhb@FreeBSD.org> of "Fri, 10 May 2002 20:29:49 EDT." <XFMail.20020510202949.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>
> On 11-May-2002 Brian Somers wrote:
> >> joerg 2002/05/10 10:56:39 PDT
> >>
> >> Modified files:
> >> sys/isa fd.c fdreg.h
> >> Log:
> >> Change the PIO loops from a hard counter into a loop that calls DELAY()
> >> in each cycle, with a tunable max cycle count defined in fdreg.h.
> >>
> >> This is said to fix the problem on some Compaq hardware (and perhaps
> >> on other machines using the Natsemi PC87317 chip) where the fdc(4)
> >> driver failed to operate at all.
> >>
> >> PR: kern/21397
> >> Submitted by: Jung-uk Kim <jkim@niksun.com>
> >> MFC after: 3 days
> >>
> >> Revision Changes Path
> >> 1.229 +14 -8 src/sys/isa/fd.c
> >> 1.16 +12 -0 src/sys/isa/fdreg.h
> >
> > As fdc is also a module, would it be better to call tsleep() instead
> > of delay if (!cold) ? Like in sys/dev/digi/digi.c:digi_delay()...
>
> Hmm, we should come up with the real fix for this quick so as to avoid
> propagating that hack any farther than we have to. :-/ (Not picking on
> you Brian).
Yes.
NetBSD has an MD delay() function in sys/arch/*/{,*/}clock.c,
prototyped in sys/arch/*/include/cpu.h. I guess I could have a go at
bringing that into FreeBSD.
> --
>
> John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
> "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
--
Brian <brian@freebsd-services.com> <brian@Awfulhak.org>
http://www.freebsd-services.com/ <brian@[uk.]FreeBSD.org>
Don't _EVER_ lose your sense of humour ! <brian@[uk.]OpenBSD.org>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205110137.g4B1binA007822>