Date: Thu, 23 Feb 2017 10:16:50 -0800 From: John Baldwin <jhb@freebsd.org> To: "Pedro F. Giffuni" <pfg@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314145 - in head/sys/dev/vxge: . vxgehal Message-ID: <114455088.Nuga6bxpH7@ralph.baldwin.cx> In-Reply-To: <201702231610.v1NGAGOK040762@repo.freebsd.org> References: <201702231610.v1NGAGOK040762@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, February 23, 2017 04:10:16 PM Pedro F. Giffuni wrote: > Author: pfg > Date: Thu Feb 23 16:10:15 2017 > New Revision: 314145 > URL: https://svnweb.freebsd.org/changeset/base/314145 > > Log: > dev/vxe: double assignments. > > Fix some suspicious code, likely caused by excessive copy-pasting. > > Found with: coccinelle (da.cocci) > MFC after: 2 weeks > > Modified: > head/sys/dev/vxge/vxge.c > head/sys/dev/vxge/vxgehal/vxgehal-config.c > > Modified: head/sys/dev/vxge/vxge.c > ============================================================================== > --- head/sys/dev/vxge/vxge.c Thu Feb 23 16:07:45 2017 (r314144) > +++ head/sys/dev/vxge/vxge.c Thu Feb 23 16:10:15 2017 (r314145) > @@ -2312,7 +2312,7 @@ vxge_vpath_open(vxge_dev_t *vdev) > vpath->rx_ticks = ticks; > > vpath->tti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; > - vpath->tti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; > + vpath->rti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; Probably use VXGE_DEFAULT_<R>TI_RTIMER_VAL instead of <T>TI? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?114455088.Nuga6bxpH7>