Date: Wed, 6 Jun 2012 21:39:49 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-fs@freebsd.org, pho@freebsd.org Subject: Re: close() of an flock'd file is not atomic Message-ID: <20120606183949.GR85127@deviant.kiev.zoral.com.ua> In-Reply-To: <201206060817.54684.jhb@freebsd.org> References: <201203071318.08241.jhb@freebsd.org> <201203091059.29342.jhb@freebsd.org> <201203161406.27549.jhb@freebsd.org> <201206060817.54684.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Jun 06, 2012 at 08:17:54AM -0400, John Baldwin wrote: > Based on feedback from Konstantin, I have split the vn_open_vnode() changes > out into a separate patch. Once that patch is in the tree I will revisit > this and update the actual bug-fix patch. > > The vn_open_vnode() patch is at > http://www.freebsd.org/~jhb/patches/vn_open_vnode.patch > > I tested it by doing a buildworld -j 32 in a loop while NFS exporting the > /usr/obj tree to another machine that did a continual find | xargs md5 loop > over the /usr/obj tree. This survived overnight. There is #if 0 left in fhopen() which translates ERESTART into EINTR. Is it needed ? Otherwise it looks fine (but still quite hard to read). [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk/Po/UACgkQC3+MBN1Mb4iWTgCdFuHxkGYMpxn4NuorK/BUAotw hX4An1rW4uWY9b4v1e8Jex037CeeZ8XY =dcfI -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120606183949.GR85127>