Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Mar 2025 01:28:51 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 1a8a24e34031 - stable/14 - acpi_iicbus: Shift slave address
Message-ID:  <202503260128.52Q1Spnr046978@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch stable/14 has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=1a8a24e34031513e9b311f55c46b9294d7aec426

commit 1a8a24e34031513e9b311f55c46b9294d7aec426
Author:     Ahmad Khalifa <ahmadkhalifa570@gmail.com>
AuthorDate: 2024-04-19 22:43:19 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2025-03-26 01:28:37 +0000

    acpi_iicbus: Shift slave address
    
    The address is expected to need shifting.
    see https://uefi.org/specs/ACPI/6.5/13_System_Mgmt_Bus_Interface_Specification.html#smbus-slave-addresses
    
    Reviewed by: imp, markj, Elliott Mitchell
    Pull Request: https://github.com/freebsd/freebsd-src/pull/1125
    
    (cherry picked from commit 67677a654aa7456f18077ccbaa9c40f39a36d21a)
---
 sys/dev/iicbus/acpi_iicbus.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sys/dev/iicbus/acpi_iicbus.c b/sys/dev/iicbus/acpi_iicbus.c
index c585f241fece..53171a72d995 100644
--- a/sys/dev/iicbus/acpi_iicbus.c
+++ b/sys/dev/iicbus/acpi_iicbus.c
@@ -255,6 +255,9 @@ acpi_iicbus_space_handler(UINT32 Function, ACPI_PHYSICAL_ADDRESS Address,
 	sc = __containerof(info, struct acpi_iicbus_softc, space_handler_info);
 	dev = sc->super_sc.dev;
 
+	/* the address is expected to need shifting */
+	sb->SlaveAddress <<= 1;
+
 	switch (Function) {
 	case AML_FIELD_ATTRIO(AML_FIELD_ATTRIB_SEND_RECEIVE, ACPI_READ):
 		val = acpi_iicbus_recvb(dev, sb->SlaveAddress, gsb->data);


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202503260128.52Q1Spnr046978>