Date: Fri, 29 Jul 2016 13:10:26 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Benjamin Kaduk <bjkfbsd@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r303484 - head/usr.bin/indent Message-ID: <b034e08b-3270-df15-4cf0-3ac52a0ccec9@FreeBSD.org> In-Reply-To: <CAJ5_RoBdhOnR6fUyXNyyMFmZnVo9mDgNQ_KFT=3Wa2Po4FU-nA@mail.gmail.com> References: <201607291617.u6TGHsPE060673@repo.freebsd.org> <CAJ5_RoC7TyFd_EC384hw0p_NHLG9EU9XHQR39CLPECyPCDjiwA@mail.gmail.com> <CAJ5_RoBdhOnR6fUyXNyyMFmZnVo9mDgNQ_KFT=3Wa2Po4FU-nA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/29/16 11:24, Benjamin Kaduk wrote: > On Fri, Jul 29, 2016 at 11:20 AM, Benjamin Kaduk <bjkfbsd@gmail.com > <mailto:bjkfbsd@gmail.com>> wrote: > > On Fri, Jul 29, 2016 at 11:17 AM, Pedro F. Giffuni <pfg@freebsd.org > <mailto:pfg@freebsd.org>> wrote: > > Author: pfg > Date: Fri Jul 29 16:17:54 2016 > New Revision: 303484 > URL: https://svnweb.freebsd.org/changeset/base/303484 > > Log: > indent(1): Fix breakage caused by single comment following "else". > > indent(1) simply wasn't taught that "else" may be followed by > a comment > without any opening brace anywhere on the line, so it was very > confused > in such cases. > > > Wrong commit message? I see no 'else' in this change. > (I guess core's guidance is to revert and recommit with correct > message, these days.) > > > Nevermind, I think I see what's going on here, now. > No problem. It would be great to have more eyes helping review the changes here: https://github.com/pstef/freebsd_indent/commits/master I only got started with a first batch of them. Regards, Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b034e08b-3270-df15-4cf0-3ac52a0ccec9>