Date: Sun, 16 Mar 2003 22:22:42 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: "M. Warner Losh" <imp@bsdimp.com> Cc: des@ofug.org, "" <mdodd@FreeBSD.org>, "" <src-committers@FreeBSD.org>, "" <cvs-src@FreeBSD.org>, "" <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/net if_iso88025subr.c Message-ID: <20030316222107.W13549@gamplex.bde.org> In-Reply-To: <20030315.173849.103229416.imp@bsdimp.com> References: <200303152237.h2FMbCCZ012310@repoman.freebsd.org> <xzpwuj0citu.fsf@flood.ping.uio.no> <20030315.173849.103229416.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 15 Mar 2003, M. Warner Losh wrote: > In message: <xzpwuj0citu.fsf@flood.ping.uio.no> > des@ofug.org (Dag-Erling Sm=F8rgrav) writes: > : "Matthew N. Dodd" <mdodd@FreeBSD.org> writes: > : > Log: > : > - Style(9) changes. > : > - Remove unneeded assignment. > : > - Increment if_oerrors as per if_fddisubr.c. > : > - Wrap ISO code with conditional. > : > : This was the 14th consecutive commit to the same file in under 6 > : hours. I think that's some kind of record... Next time, please test > : before committing. > > I don't see Matt's changes as a lack of testing. he's doing what > people have always done. I did it many times in the oldcard code when > I wanted to make each change separately on purpose. Yes, please keep separate changes separate, even if it takes longer to test each step. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030316222107.W13549>