Date: Tue, 26 Nov 2002 00:10:20 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Olivier Houchard <cognet@ci0.org> Cc: freebsd-audit@FreeBSD.ORG Subject: Re: do_dup patch Message-ID: <20021126000957.B430-100000@gamplex.bde.org> In-Reply-To: <20021125121747.GA11569@ci0.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 25 Nov 2002, Olivier Houchard wrote:
> On Mon, Nov 25, 2002 at 11:07:53PM +1100, Bruce Evans wrote:
> > %%%
> > Index: kern_descrip.c
> > ===================================================================
> > RCS file: /home/ncvs/src/sys/kern/kern_descrip.c,v
> > retrieving revision 1.168
> > diff -u -2 -r1.168 kern_descrip.c
> > --- kern_descrip.c 27 Oct 2002 18:07:41 -0000 1.168
> > +++ kern_descrip.c 25 Nov 2002 11:56:27 -0000
> > @@ -471,6 +475,6 @@
> > */
> > FILEDESC_LOCK(fdp);
> > - if (old >= fdp->fd_nfiles || fdp->fd_ofiles[old] == NULL ||
> > - new >= p->p_rlimit[RLIMIT_NOFILE].rlim_cur ||
> > + if (old < 0 || old >= fdp->fd_nfiles || fdp->fd_ofiles[old] == NULL ||
> > + new < 0 || new >= p->p_rlimit[RLIMIT_NOFILE].rlim_cur ||
> > new >= maxfilesperproc) {
> > FILEDESC_UNLOCK(fdp);
> > %%%
>
> I just tested the same change and it is ok.
> Shall I submit it to re@ or will you do it ?
Please do it.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021126000957.B430-100000>