Date: Mon, 14 Jan 2019 12:13:39 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: rgrimes@freebsd.org Cc: Takahashi Yoshihiro <nyan@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343011 - in head/kerberos5: lib/libasn1 lib/libgssapi_krb5 lib/libhdb lib/libheimntlm lib/libhx509 lib/libkadm5clnt lib/libkadm5srv lib/libkdc lib/libkrb5 lib/libwind libexec/digest-se... Message-ID: <201901142013.x0EKDdsA004741@slippy.cwsent.com> In-Reply-To: Message from "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> of "Mon, 14 Jan 2019 08:17:58 -0800." <201901141617.x0EGHwqQ035748@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <201901141617.x0EGHwqQ035748@pdx.rh.CN85.dnsmgr.net>, "Rodney W. Gri mes" writes: > > Author: nyan > > Date: Mon Jan 14 06:34:54 2019 > > New Revision: 343011 > > URL: https://svnweb.freebsd.org/changeset/base/343011 > > > > Log: > > Use ${SRCTOP}/contrib/com_err/com_err.h instead of the installed com_err. > h. > > This fixes build when com_err.h is not installed. > > Isn't this the general state of affairs for almost all > of the source tree? I would rather see this solved > in a general way, rather than sprinkly all this > -I${SRCTOP} all over in the tree. Agreed however in practice this is fixed when discovered while working on other issues/problems/projects. > > It use to be (and maybe still is) required that you run > cd $DRCTOP && make includes > if you expected new source code to compile. I expect > this has changed, but the just of it should work in > some aspect. This fixes the potential bug of requiring a header file to be installed. I suspect this to be an oversight at the time. Good that it's fixed now. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201901142013.x0EKDdsA004741>