Date: Sat, 26 Aug 2017 16:55:33 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 221676] arp: invalid json output from libxo when bridge is present Message-ID: <bug-221676-2472-R974E7fRwv@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-221676-2472@https.bugs.freebsd.org/bugzilla/> References: <bug-221676-2472@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221676 Duncan Paterson <duncan@splash.fish> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |duncan@splash.fish --- Comment #1 from Duncan Paterson <duncan@splash.fish> --- Created attachment 185787 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=185787&action=edit Adds the quote directive to xo fields to make sure that strings are quoted in json output I can reproduce this in general for libxo. The number detecting heuristic it uses allows for C style numeric suffices (for example 34f, 12d). This allows any strings ending the characters in the set [diouDOUeEfFgG] to be treated as numbers (left unquoted in json). This has two drawbacks firstly leaving strings such as bridge unquoted because it ends in e, secondly it allows numbers with C style suffices to be output unqoted these are not valid json. for example: { "key": 35f } is invalid. I've added the quote directive to all of the relevant xo_emit calls as per the documentation on libxo at http://juniper.github.io/libxo/libxo-manual.html. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-221676-2472-R974E7fRwv>