Date: Thu, 21 Nov 2019 06:33:11 -0500 From: Ed Maste <emaste@freebsd.org> To: Pete Wright <pete@nomadlogic.org> Cc: Glen Barber <gjb@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: breakage at usr.sbin/jail/Makefile Message-ID: <CAPyFy2C17iUB49MnWJwOkqfwF4pRV6XnrnR5fdc%2BMFhKAXkFug@mail.gmail.com> In-Reply-To: <38318920-7d3b-ee08-b0d0-d6e04e03c6a3@nomadlogic.org> References: <0e3dd332-91d7-0aa1-43cb-43528db7c63a@nomadlogic.org> <20191121041317.GL5599@FreeBSD.org> <38318920-7d3b-ee08-b0d0-d6e04e03c6a3@nomadlogic.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 20 Nov 2019 at 23:19, Pete Wright <pete@nomadlogic.org> wrote:
>
> the issue seems to be on my amd64 system ${LINKER_TYPE} is not defined.
> i was contemplating suggesting updating the .if clause in the Makefile
> like so:
>
> .if defined($LINKER_TYPE}) && ${LINKER_TYPE} == "bfd" && ${MACHINE} ==
> "riscv"
Yes, this is the approach I went with - Cirrus-CI started building my
proposed change last night but it wasn't finished before I was. When I
checked this morning it confirmed the fix works. In any case the best
fix here will be to resolve the underlying RISC-V binutils issue and
revert all of the workarounds.
Note that FreeBSD's CI did not catch this issue because it builds with
-DNO_CLEAN. I also build locally with -DNO_CLEAN and wouldn't have
seen it either. In my opinion we ought to just remove the not-NO_CLEAN
case from buildworld/buildkernel.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2C17iUB49MnWJwOkqfwF4pRV6XnrnR5fdc%2BMFhKAXkFug>