Date: Sat, 7 Oct 2006 04:39:42 GMT From: Warner Losh <imp@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 107394 for review Message-ID: <200610070439.k974dgnr002418@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=107394 Change 107394 by imp@imp_lighthouse on 2006/10/07 04:38:56 Wow. That's a common bug. Check irq_res when allocating an interrupt. Affected files ... .. //depot/projects/arm/src/sys/arm/at91/at91_ssc.c#9 edit .. //depot/projects/arm/src/sys/arm/at91/at91_twi.c#25 edit .. //depot/projects/arm/src/sys/arm/at91/if_ate.c#56 edit Differences ... ==== //depot/projects/arm/src/sys/arm/at91/at91_ssc.c#9 (text+ko) ==== @@ -176,7 +176,7 @@ rid = 0; sc->irq_res = bus_alloc_resource_any(dev, SYS_RES_IRQ, &rid, RF_ACTIVE); - if (sc->mem_res == NULL) + if (sc->irq_res == NULL) goto errout; return (0); errout: ==== //depot/projects/arm/src/sys/arm/at91/at91_twi.c#25 (text+ko) ==== @@ -173,7 +173,7 @@ rid = 0; sc->irq_res = bus_alloc_resource_any(dev, SYS_RES_IRQ, &rid, RF_ACTIVE); - if (sc->mem_res == NULL) + if (sc->irq_res == NULL) goto errout; return (0); errout: ==== //depot/projects/arm/src/sys/arm/at91/if_ate.c#56 (text+ko) ==== @@ -333,7 +333,7 @@ rid = 0; sc->irq_res = bus_alloc_resource_any(dev, SYS_RES_IRQ, &rid, RF_ACTIVE); - if (sc->mem_res == NULL) + if (sc->irq_res == NULL) goto errout; /*
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610070439.k974dgnr002418>