Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 1 Sep 2001 16:28:53 -0500
From:      Alfred Perlstein <bright@mu.org>
To:        Julian Elischer <julian@elischer.org>
Cc:        Matt Dillon <dillon@earth.backplane.com>, Peter Wemm <peter@wemm.org>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/kern subr_prof.c kern_ntptime.c kern_xxx.c
Message-ID:  <20010901162853.A81307@elvis.mu.org>
In-Reply-To: <3B914D42.478B3FE@elischer.org>; from julian@elischer.org on Sat, Sep 01, 2001 at 02:04:02PM -0700
References:  <20010901074325.28AE13807@overcee.netplex.com.au> <200109010827.f818RW370778@earth.backplane.com> <20010901135013.Y81307@elvis.mu.org> <3B914D42.478B3FE@elischer.org>

next in thread | previous in thread | raw e-mail | index | archive | help

* Julian Elischer <julian@elischer.org> [010901 16:12] wrote:
> Alfred Perlstein wrote:
> > 
> > * Matt Dillon <dillon@earth.backplane.com> [010901 03:27] wrote:
> > >
> > >     Also, since I'm in critique mode... for gods sake, LAY OFF THE
> > >     MULTI-LINE MACROS AND INLINES FOR COMMON PROCEDURE CALLS!!  The bloat
> > >     they are causing is unbelievable.
> > 
> > Agreed, those are really bad.
> > 
> Which ones are you refering to?

I was making a general statement that heavily used macros that
expand (especially into mtx_lock()) are particularly painful
in regards to bloat and busting icache.

-- 
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
start asking why software is ignoring 30 years of accumulated wisdom.'

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010901162853.A81307>