Date: Mon, 3 Jan 2005 09:53:14 +1100 From: Edwin Groothuis <edwin@mavetju.org> To: Kris Kennaway <kris@obsecurity.org> Cc: Xin LI <delphij@frontfree.net> Subject: Re: cvs commit: ports/mail/postfix-gps Makefile Message-ID: <20050102225314.GJ63708@k7.mavetju> In-Reply-To: <20050102223941.GA75006@xor.obsecurity.org> References: <200501020116.j021GBqD070105@repoman.freebsd.org> <20050102064857.GA4047@frontfree.net> <20050102065949.GB6250@xor.obsecurity.org> <20050102070800.GA106@frontfree.net> <20050102071136.GD1436@k7.mavetju> <20050102071849.GA31292@xor.obsecurity.org> <20050102112037.GE1436@k7.mavetju> <20050102201818.GA42186@xor.obsecurity.org> <20050102213206.GI63708@k7.mavetju> <20050102223941.GA75006@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 02, 2005 at 02:39:41PM -0800, Kris Kennaway wrote: > On Mon, Jan 03, 2005 at 08:32:06AM +1100, Edwin Groothuis wrote: > > On Sun, Jan 02, 2005 at 12:18:18PM -0800, Kris Kennaway wrote: > > > On Sun, Jan 02, 2005 at 10:20:37PM +1100, Edwin Groothuis wrote: > > > > > > > > The problem is that INDEX builds also need to set this or the > > > > > dependency list will be all wrong. Doing this the obvious way gives a > > > > > huge slowdown. > > > > > > > > What are the obvious ways? This is what I made in a galaxy far far > > > > away when I still had the hope I could change the world. What is > > > > does is when PACKAGE_BUILDING is defined it sets the default WITH_ > > > > and WITHOUT_ values are being set. > > > > > > And that gives a huge slowdown, because of all the extra make/shell > > > gunk that is processed 12000 times :) > > > > I couldn't find a single shell command in this. > > OK (I might have been confusing it with the slowdown that happened > along with a previously-committed OPTIONS-related change) but did you > benchmark it? I would like to, but at this moment I'm not sure what and how: - It doesn't have any impact on ports when PACKAGE_BUILDING isn't set. - It doesn't have any impact on ports which don't use OPTIONS. - When running it without PACKAGE_BUILDING set, it takes half a second for databases/libdbi-drivers. When running it with PACKAGE_BUILDING set, it takes 2.5 seconds. Why? Because it has to go through the databases/mysql40-client and databases/postgresql7 ports and find their dependencies. So yes with this patch it's slower, but that is because it does do all the intended work instead of bailing out halfway. -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://weblog.barnet.com.au/edwin/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050102225314.GJ63708>