Date: Sat, 28 Mar 2026 08:51:19 +0100 From: Andre Albsmeier <mail@fbsd2.e4m.org> To: Warner Losh <imp@bsdimp.com> Cc: Andre Albsmeier <mail@fbsd2.e4m.org>, Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@freebsd.org>, Enji Cooper <ngie@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: Removing stuff from NOTES because it is in GENEREIC Message-ID: <aceId7T8Ba9YhBJ5@voyager.c4ef04bb578971607fc6a73f3188a722> In-Reply-To: <CANCZdfovETtvAA7i_c=Gaaq40NMj-jU_nTAnSNTFSGdrjuhkfQ@mail.gmail.com> References: <695c68c6.3ff5d.593fc2c7@gitrepo.freebsd.org> <acT22c_lPC5WMfVd@voyager.c4ef04bb578971607fc6a73f3188a722> <86ldfeyggv.fsf@ltc.des.dev> <acZFnCicseAm9KpM@voyager.c4ef04bb578971607fc6a73f3188a722> <CANCZdfovETtvAA7i_c=Gaaq40NMj-jU_nTAnSNTFSGdrjuhkfQ@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Fri, 27-Mar-2026 at 22:33:46 -0600, Warner Losh wrote:
> On Fri, Mar 27, 2026 at 2:54 AM Andre Albsmeier <mail@fbsd2.e4m.org> wrote:
>
> > On Thu, 26-Mar-2026 at 12:31:44 +0100, Dag-Erling Smørgrav wrote:
> > > Andre Albsmeier <mail@fbsd2.e4m.org> writes:
> > > > Is it correct to remove something from NOTES because it is in GENERIC?
> > > >
> > > > My impression was that NOTES contains ALL what can be configured into
> > > > a kernel (whether it makes sense or not). Am I wrong here?
> > >
> > > You are correct. NOTES is intended to have all options that can be
> > > enabled, plus non-default values for all parameters that can be tuned.
> >
> > OK, thanks to you and Warner for clarifying.
> >
> > When checking sys/amd64/conf/GENERIC on -HEAD, I found the following
> > items which are not in sys/{.,x86,amd64}/conf/NOTES:
> >
> > device ocs_fc
> > device tws
> > device ufshci
> > device aq
> > device vge
> >
>
> These are needed. I'll commit.
>
>
> > option EXTERR_STRINGS
> > option IPSEC_OFFLOAD
> > option FIB_ALGO
> > option PRINTF_BUFR_SIZE
> > option KDTRACE_FRAME
> > option DDB_CTF
> > option RACCT_DEFAULT_TO_DISABLED
> > option AH_AR5416_INTERRUPT_MITIGATION
> >
> > Should they be added?
> >
>
> These are in GENERIC and not LINT, so we get things done both ways.
Sorry, I don't understand entirely. Most options we find in GENERIC
are also in one of the NOTES. So why shouldn't those above not be
included as well?
Or, in other words: Why, just as an example, do we have
options IEEE80211_DEBUG
options IEEE80211_SUPPORT_MESH
options USB_DEBUG
in NOTES when they are already in GENERIC?
-Andre
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aceId7T8Ba9YhBJ5>