Date: Sun, 21 Oct 2018 11:55:20 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: Glen Barber <gjb@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339436 - in head: . contrib/gcc gnu/usr.bin/cc/cc_tools lib/clang release sys/conf sys/sys Message-ID: <F64E20B4-576A-44DA-B727-EFDA7D4EF51E@FreeBSD.org> In-Reply-To: <o9bo-oxuj-wny@FreeBSD.org> References: <201810190037.w9J0blks031617@repo.freebsd.org> <o9bo-oxuj-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_327A302A-8CB5-457E-94EE-80BE203B84AB
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=us-ascii
On 21 Oct 2018, at 04:08, Jan Beich <jbeich@FreeBSD.org> wrote:
>=20
> Glen Barber <gjb@FreeBSD.org> writes:
>=20
>> Modified: head/lib/clang/llvm.build.mk
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- head/lib/clang/llvm.build.mk Fri Oct 19 00:24:23 2018 =
(r339435)
>> +++ head/lib/clang/llvm.build.mk Fri Oct 19 00:37:47 2018 =
(r339436)
>> @@ -17,7 +17,7 @@ CFLAGS+=3D -I${LLVM_SRCS}/include
>> CFLAGS+=3D -DLLVM_BUILD_GLOBAL_ISEL
>> CFLAGS+=3D -D__STDC_LIMIT_MACROS
>> CFLAGS+=3D -D__STDC_CONSTANT_MACROS
>> -#CFLAGS+=3D -DNDEBUG
>> +CFLAGS+=3D -DNDEBUG
>=20
> Would Clang still hit asserts instead of crashing with cryptic =
messages?
In llvm, assertions (and various other internal consistency checks) are
turned off by defining NDEBUG. So indeed, if something in the internal
state goes in an unexpected direction, you could get crashes or other
"interesting" effects.
That said, the resulting executable(s) should run somewhat faster, and
be somewhat smaller. I think we have always done this for stable
branches and releases.
If users encounter such crashes, it will still write reproduction files
(self-contained .c or .cpp file and a shell script), so those can be
included in bug reports, and run on a copy of clang with assertions.
-Dimitry
--Apple-Mail=_327A302A-8CB5-457E-94EE-80BE203B84AB
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.2
iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCW8xNCAAKCRCwXqMKLiCW
oyaXAKDXEZI/4cWTB0qr543kJc1XjK6q6wCg7D8vIQthMTJMRptfRii+bIs5uDE=
=NuZA
-----END PGP SIGNATURE-----
--Apple-Mail=_327A302A-8CB5-457E-94EE-80BE203B84AB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F64E20B4-576A-44DA-B727-EFDA7D4EF51E>