Date: Thu, 12 Feb 2015 14:06:02 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Brad Davis <brd@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, oneil.rs@gmail.com Subject: Re: svn commit: r278475 - head/usr.sbin/pw/tests Message-ID: <39C8D48F-1962-4393-8FF3-C96DDBF6721E@gmail.com> In-Reply-To: <201502092115.t19LFrEk019578@svn.freebsd.org> References: <201502092115.t19LFrEk019578@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_400BC6BF-32A8-4232-B469-38FA9E43C759 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 Hi Brad, On Feb 9, 2015, at 13:15, Brad Davis <brd@FreeBSD.org> wrote: > Author: brd (doc committer) > Date: Mon Feb 9 21:15:52 2015 > New Revision: 278475 > URL: https://svnweb.freebsd.org/changeset/base/278475 >=20 > Log: > Add tests for `pw usernext'. >=20 > PR: 197120 > Submitted by: Robert O'Neil <oneil.rs@gmail.com> > Approved by: will >=20 > Added: > head/usr.sbin/pw/tests/pw_usernext.sh (contents, props changed) > Modified: > head/usr.sbin/pw/tests/Makefile =85 > + var0=3D1 > + LIMIT=3D`jot -r 1 2 10` > + while [ "$var0" -lt "$LIMIT" ] > + do > + atf_check -s exit:0 ${PW} useradd -n test$var0 -g 0 > + var0=3D`expr $var0 + 1` > + done > + atf_check -s exit:0 -o match:"100${LIMIT}:1001}=94 \ This line is incorrect (there=92s a trailing `}` after 1001). Removing it will fix the test, but is assuming that 1001 will always be = the next group correct (it=92s correct in the default install, but IIRC = it wasn=92t correct if you started groups at gid=3D500)? Wouldn=92t it be safer to create a bogus group, get the gid for the = group, then test to ensure that that god is matched? Thanks! --Apple-Mail=_400BC6BF-32A8-4232-B469-38FA9E43C759 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJU3SPKAAoJEMZr5QU6S73e/6QH/1HgIs9AuzdL/Ehvh/XI8YL7 pgbLjBYbwm4S/sZt7cMaMhU+idyy54el3Lka5RRccPutdoF+AbG0uQ2FPLzMafoW 26lTVlRNXT7kpc0HWIAhY/z6ru8HG1Hd/Cxs2pLOI1LvEBKiLrDgrb0rnTMAt3hD Yvrk5wsAHR6nCUmNEYzH6s1QSGrOVwKNjMRl5A1O6mlGhPoogH3cLHkinU+dVHzK Ckv/d+ZmAiZHJq1YJ5E51Bd8+xSOGYD+xwQU2CFHdAwycu/2p8OkxIj5DbtccUDl Cpc2Ccykzw3XMZMk/O1KTjeYcA1g1UZdQ9OQJvMEfDGK1MJesrsoJ/biXSFYRPg= =PTxS -----END PGP SIGNATURE----- --Apple-Mail=_400BC6BF-32A8-4232-B469-38FA9E43C759--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?39C8D48F-1962-4393-8FF3-C96DDBF6721E>