Date: Sun, 10 Oct 1999 02:19:36 -0700 From: Chris Piazza <cpiazza@home.net> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Sheldon Hearn <sheldonh@uunet.co.za>, Chris Piazza <cpiazza@home.net>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 style.9 Message-ID: <19991010021936.B276@norn.ca.eu.org> In-Reply-To: <14180.939546954@critter.freebsd.dk> References: <73957.939546778@axl.noc.iafrica.com> <14180.939546954@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 10, 1999 at 11:15:54AM +0200, Poul-Henning Kamp wrote: > In message <73957.939546778@axl.noc.iafrica.com>, Sheldon Hearn writes: > > > > > >On Sun, 10 Oct 1999 02:04:21 MST, Chris Piazza wrote: > > > >> > (p = f()) == NULL) > >> > >> Hmm, you're right I guess. I was reading it as if(... > >> > >> Should I revert this or change it? > > > >Changing it and the example below it to if statements would probably > >make the fragments more consistent with other examples of tests in the > >style.9 manpage. Whatever you do, just make sure you end up with a > >consistent style at the end of the day. ;-) > > Apart from the fact that we discourage assignments inside if (...) Of course two examples 15 or so lines down do exactly that... -Chris To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19991010021936.B276>