Date: Fri, 19 Sep 2014 12:12:39 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: Adrian Chadd <adrian@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Bruce Simpson <bms@fastmail.net>, Gleb Smirnoff <glebius@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Kevin Lo <kevlo@freebsd.org> Subject: Re: svn commit: r271735 - head/sys/net Message-ID: <CAOfEmZhM-N_cqWZ=AgtQm0vMLDeOuPEyu2L1jiyPBqYJgD976A@mail.gmail.com> In-Reply-To: <CAOfEmZgBmy6eMCrtPZFgL087OJ1NMUpk47uV66eR4cCunLHZLg@mail.gmail.com> References: <201409180309.s8I39Zmh045601@svn.freebsd.org> <20140918051834.GD89442@FreeBSD.org> <20140918060435.GA5856@ns.kevlo.org> <1411024874.128099.168895241.4A95DCA1@webmail.messagingengine.com> <CAJ-VmokuWVsxGetiEg_1PxicsiD5nXMK1Bm1AFUuMMNf7VjyvA@mail.gmail.com> <CAOfEmZgBmy6eMCrtPZFgL087OJ1NMUpk47uV66eR4cCunLHZLg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello, I made some tests with the implementation from pfsense and it works like a charm with very few modifications. I'm gonna try to make it in two steps. 1) First only submit the vlan(4) and ifconfig(8) changes. 2) Submit the changes on pf(4) and ipfw(8) in a second stage. I'm going to use phabricator to make easier the follow up, byt the way, the patch from pfsense partially was made by rwatson@. I'm gonna add rwatson to the review. Best Regards, 2014-09-18 23:41 GMT+08:00 Marcelo Araujo <araujobsdport@gmail.com>: > Hello Adrian, > > I have a patch, but it is a hack on PF and some very ugly code. Not > generic at all. > As my hands are dirty now with it, if you don't have too much time, I can > take a look on pfsense implementation. > > Best Regards, > > 2014-09-18 22:32 GMT+08:00 Adrian Chadd <adrian@freebsd.org>: > >> There is in pfsense. >> >> Let me see about twisting some arms again... :) >> >> >> -a >> >> >> On 18 September 2014 00:21, Bruce Simpson <bms@fastmail.net> wrote: >> > On Thu, 18 Sep 2014, at 07:04, Kevin Lo wrote: >> >> Sorry, I overlooked that. Marcelo has a patch with 802.1p tagging >> >> support, >> >> I thought the patch was committed. >> > >> > I agree the comment change should be reverted. I changed if_ethersubr.c >> > many years ago to decode 802.1p tags into the mbuf packet header if they >> > are present. >> > >> > However, to my knowledge, there is no support (e.g. in the form of a >> > DiffServ / IntServ mapping) further up in the stack. If someone plans to >> > add this, great -- that would be needed for any form of tangible 802.1p >> > support. >> > >> > -- >> > BMS (sent via webmail) >> > >> > > > > -- > > -- > Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^ > Power To Server. .\. /_) > > -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^ Power To Server. .\. /_)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZhM-N_cqWZ=AgtQm0vMLDeOuPEyu2L1jiyPBqYJgD976A>