Date: Mon, 17 Oct 2011 22:56:50 +0800 From: Adrian Chadd <adrian@freebsd.org> To: "Jayachandran C." <jchandra@freebsd.org> Cc: freebsd-mips@freebsd.org Subject: Re: svn commit: r225892 - head/sys/mips/mips Message-ID: <CAJ-VmomE=A3J_t6JKSEPTrBmeLE6Y%2BqAKtgn_yb4u7r-O%2B7DRQ@mail.gmail.com> In-Reply-To: <CA%2B7sy7BYALEDz=OR1k-GPjOpcHP5dK8mKG-A_J5LJ2jO2R04KA@mail.gmail.com> References: <CA%2B7sy7BiRvTB79H9=y%2BS4jQ=%2BboW1bcDJn%2BBULMmJU9KLLVJ5A@mail.gmail.com> <CAJ-VmokAsDpjJLt%2BVJ2gDGX%2BiMAwZvL2TPaaAD_LRm-Yyquxig@mail.gmail.com> <CA%2B7sy7D6h5a08Q6yNfX6xSqwabDLzE5GLu5aV3fCMYQKn_4AoQ@mail.gmail.com> <CAJ-Vmon32cVEVvC=3WJVmDkCUdyLWyec3sqU-ifzspVSPxedfg@mail.gmail.com> <CAJ-Vmomsq5PQzbCBmWob5juB9EqdcEoYV%2B9vwYjnJQYTo_%2B4kw@mail.gmail.com> <CAJ-Vmon_a_zLZmEGqwFaYaobjYFE2i1u2Viq3QD5dw4wpNNURA@mail.gmail.com> <CA%2B7sy7DFCMxo-2bJwBJcSEJf7ewG7Y=XwdgKXkhpRyDXQpvsYA@mail.gmail.com> <CAJ-VmokPFqS2oNWZ_mFSxy=0MXfgqtOcBHSQe%2BdYXvsLHAyGjQ@mail.gmail.com> <CAJ-VmomqmKPRHBCbt46_xXD0VoU47Q-vYWbAqCFaM635ZnOHWA@mail.gmail.com> <CAJ-VmomLbueaG3bmnT0WfeKaMSyXSNo80BWXqEe39z6x%2Bx8QoA@mail.gmail.com> <20111002110331.GF1511@deviant.kiev.zoral.com.ua> <CA%2B7sy7A%2Bq_N6Hr%2B3-tD=BJxmqtDgBeWF9HJCtopLF0RUz6hVyw@mail.gmail.com> <CA%2B7sy7Ax9SXSK1CyxuBNboktJxuQTMiu3D4NFmZSoq7-ipoQgA@mail.gmail.com> <CA%2B7sy7Cin5-cHcP-8_qYGhpEnAN9gw6S5ekXYK6Q3X9FREQggA@mail.gmail.com> <CAJ-VmokSNa%2BBSxeO=s%2BLrNE%2BnMD8_b4Yx51i_5E%2B8K2nkrxRsw@mail.gmail.com> <CAJ-VmomYcmua1cUb6F-U3VOHjAfzr19COB5at=jd-4f=mt3agg@mail.gmail.com> <CA%2B7sy7Bh3KxOnLoPfWP_3QGN2F4WExLDfeMeoTLqRb3RCWT6PA@mail.gmail.com> <CA%2B7sy7BYALEDz=OR1k-GPjOpcHP5dK8mKG-A_J5LJ2jO2R04KA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17 October 2011 22:18, Jayachandran C. <jchandra@freebsd.org> wrote: >> The patch does not cause any further problems =A0for me on XLR/XLP - I >> have been testing it for a few days. =A0But I don't really have a >> testcase for the issue you see. > > If there are no objections, I'm planning to check this in. > > =A0I can keep the two if(!busy) blocks in cpu_idle() commented if you > prefer, and that should give the same behavior as you are seeing now. I'm happy for you to check it in. I'll do some further testing in my branch and see if I can figure out why it isn't working for me. I've also found the relevant bits in the mips24k programming pdfs which talk about the Config7 bit which indiciates whether wait will break if a mask interrupt is asserted or not. That may be good to include at a later date. (But my SoCs don't have that feature, so we still need this WAR.) Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomE=A3J_t6JKSEPTrBmeLE6Y%2BqAKtgn_yb4u7r-O%2B7DRQ>