Date: Thu, 25 Oct 2018 12:27:17 +0000 (UTC) From: Hans Petter Selasky <hselasky@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r339708 - stable/12/sys/dev/sound/midi Message-ID: <201810251227.w9PCRHel080419@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: hselasky Date: Thu Oct 25 12:27:16 2018 New Revision: 339708 URL: https://svnweb.freebsd.org/changeset/base/339708 Log: MFC r339581: Fix off-by-one which can lead to panics. Found by: Peter Holm <peter@holm.cc> Approved by: re (kib) Sponsored by: Mellanox Technologies Modified: stable/12/sys/dev/sound/midi/sequencer.c Directory Properties: stable/12/ (props changed) Modified: stable/12/sys/dev/sound/midi/sequencer.c ============================================================================== --- stable/12/sys/dev/sound/midi/sequencer.c Thu Oct 25 12:13:13 2018 (r339707) +++ stable/12/sys/dev/sound/midi/sequencer.c Thu Oct 25 12:27:16 2018 (r339708) @@ -730,7 +730,7 @@ static int seq_fetch_mid(struct seq_softc *scp, int unit, kobj_t *md) { - if (unit > scp->midi_number || unit < 0) + if (unit >= scp->midi_number || unit < 0) return EINVAL; *md = scp->midis[unit];
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201810251227.w9PCRHel080419>