Date: Fri, 2 Apr 2010 02:12:31 +0200 From: Joerg Sonnenberger <joerg@britannica.bec.de> To: svn-src-all@freebsd.org Subject: Re: svn commit: r206043 - in head/usr.sbin/pkg_install: add delete lib version Message-ID: <20100402001231.GA16732@britannica.bec.de> In-Reply-To: <k2m7d6fde3d1004011702ha697cd7bg96cf6bd8f58babb4@mail.gmail.com> References: <201004011427.o31ERTaT056824@svn.freebsd.org> <k2m7d6fde3d1004011702ha697cd7bg96cf6bd8f58babb4@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 01, 2010 at 05:02:34PM -0700, Garrett Cooper wrote: > 1. FILENAME_MAX could be less than PATH_MAX, and actually is on > the BSDs (256 vs 1024). PATH_MAX allows for duplicate slashes and all > sorts of whacky path crud and probably should be used more liberally > in the pkg_install code. This however isn't always true in the NetBSD > case because they're aiming for portability of pkg_install, however > PATH_MAX is always guaranteed to be at least as large as FILENAME_MAX. Well, I've been slowly working on eliminating the use of PATH_MAX in the NetBSD/pkgsrc version of pkg_install. The performance gain from using fixed stack space is minimal and the error handling generally incompletely at best. Joerg
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100402001231.GA16732>