Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 5 Apr 2002 13:26:37 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        "David E. O'Brien" <obrien@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject:   Re: cvs commit: src/usr.bin/yacc reader.c
Message-ID:  <20020405131509.C2961-100000@gamplex.bde.org>
In-Reply-To: <200204042210.g34MAOp67222@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 4 Apr 2002, David E. O'Brien wrote:

> obrien      2002/04/04 14:10:24 PST
>
>   Modified files:
>     usr.bin/yacc         reader.c
>   Log:
>   Revert revision 1.3.  This is WARNS=4 clean w/o it and it only increases
          ^ one line of
>   the diffs to Open/NetBSD.
>
>   Revision  Changes    Path
>   1.15      +1 -1      src/usr.bin/yacc/reader.c

This seems to reintroduce a bug.  The "spacing" variable seems to be used
uniinitialized to me.  The changed version only compiles clean because
WARNS is intentionally broken.  From bsd.sys.mk:

.  if ${WARNS} > 1
# XXX Delete -Wuninitialized by default for now -- the compiler doesn't
# XXX always get it right.
CFLAGS		+=	-Wno-uninitialized
.  endif

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020405131509.C2961-100000>