Date: Mon, 23 Feb 1998 14:03:40 -0800 From: Mike Smith <mike@smith.net.au> To: The Hermit Hacker <scrappy@hub.org> Cc: freebsd-current@FreeBSD.ORG Subject: Re: ATAPI related patch .. Message-ID: <199802232203.OAA12585@dingo.cdrom.com> In-Reply-To: Your message of "Mon, 23 Feb 1998 17:40:25 -0400." <Pine.BSF.3.96.980223173713.241D-100000@thelab.hub.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > I recently grabbed a patch that Luigi (freebsd-multimedia) has > that is required in order to read audio tracks (using something like > tosha) from a CD...with minor modifications, I've got it in my -current > kernel and haven't noticed any problems. Thanks for the review! > I would like to commit the patch to the -current source tree, so > am asking here if there are any objections to doing this. If I hear > nothing by Wednesday (long enough?), I'll assume that it is okay and > commit it... Erk. This is thoroughly grostic. You shouldn't be doing I/O using an ioctl; this behaviour should belong on a new minor number and the raw device read handler. I would vote against the inclusion of this code, unless there is an overwhelming precedent for the technique. -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199802232203.OAA12585>