Date: Tue, 18 Aug 2020 15:37:50 +0200 From: Mateusz Guzik <mjguzik@gmail.com> To: current@freebsd.org, Mateusz Guzik <mjguzik@gmail.com> Subject: Re: "panic: malloc(M_WAITOK) in non-sleepable context" after r364296 -> r364341 Message-ID: <CAGudoHG8ZcwcoPzs33WXTVcRZ0APRiABMNCR--KgUDwF%2BgosGg@mail.gmail.com> In-Reply-To: <20200818132902.GQ1394@albert.catwhisker.org> References: <20200818124419.GO1394@albert.catwhisker.org> <CAGudoHEEnZVaBwY1L-wjmDcrsHyP4pE3-0qyurh-kWsCO9Edhg@mail.gmail.com> <20200818125825.GP1394@albert.catwhisker.org> <CAGudoHHJLoQhU%2Bb4%2Btt_dmChYj=qXA%2BiVaC5mFW8sFxoqq54pw@mail.gmail.com> <20200818132902.GQ1394@albert.catwhisker.org>
next in thread | previous in thread | raw e-mail | index | archive | help
So the previous patch should just print a warning.
Does this take care of the problem in general? I don't have means to
test the patch.
diff --git a/sys/cam/scsi/scsi_pass.c b/sys/cam/scsi/scsi_pass.c
index b299fbddd84..c6d6a5da403 100644
--- a/sys/cam/scsi/scsi_pass.c
+++ b/sys/cam/scsi/scsi_pass.c
@@ -652,6 +652,7 @@ passregister(struct cam_periph *periph, void *arg)
args.mda_gid = GID_OPERATOR;
args.mda_mode = 0600;
args.mda_si_drv1 = periph;
+ args.mda_flags = MAKEDEV_NOWAIT;
error = make_dev_s(&args, &softc->dev, "%s%d", periph->periph_name,
periph->unit_number);
if (error != 0) {
On 8/18/20, David Wolfskill <david@catwhisker.org> wrote:
> On Tue, Aug 18, 2020 at 03:24:52PM +0200, Mateusz Guzik wrote:
>> Try this:
>> [replacing new KASSERT() with WITNESS_WARN()...]
>> ....
>
> Thanks; on it. Should take care of it, I think.
>
> Peace,
> david
> --
> David H. Wolfskill david@catwhisker.org
> Donald Trump is either ignorant of how to govern or is refusing to do so.
>
> See http://www.catwhisker.org/~david/publickey.gpg for my public key.
>
--
Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHG8ZcwcoPzs33WXTVcRZ0APRiABMNCR--KgUDwF%2BgosGg>