Date: Mon, 8 Jul 2002 15:12:43 +0800 From: "David Xu" <davidx@viasoft.com.cn> To: <current@FreeBSD.ORG>, "Peter Wemm" <peter@wemm.org> Subject: Re: Remember my ill-fated i386 smp pmap optimizations? Message-ID: <01d801c2264e$db1b4fe0$ef01a8c0@davidwnt> References: <20020708062855.02DE03808@overcee.wemm.org>
index | next in thread | previous in thread | raw e-mail
Gartner: Apache is vulnerable, we recommend switching back to IIS to protect yourselves
----- Original Message -----
From: "Peter Wemm" <peter@wemm.org>
To: <current@FreeBSD.ORG>
Sent: Monday, July 08, 2002 2:28 PM
Subject: Remember my ill-fated i386 smp pmap optimizations?
> A few months ago, I had a bit of a disaster with some pmap optimizations.
> After committing, all hell broke loose. It was backed out completely.
>
> I finally found the problem (diff cleaned up to highlight the problem):
>
> pmap_mapdev()
> ...
> for (tmpva = va; size > 0; ) {
> pte = vtopte(tmpva);
> *pte = pa | PG_RW | PG_V | pgeflag;
> size -= PAGE_SIZE;
> tmpva += PAGE_SIZE;
> - pa += PAGE_SIZE;
:(
> }
> invltlb();
>
> Excuse me while I go outside and shoot myself.
>
> Cheers,
> -Peter
> --
> Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
> "All of this is for nothing if we don't go to the stars" - JMS/B5
sorry for a bit OT, but why are pmap_mapdev and pmap_unmapdev still using
old C language parameter style? I saw other functions in pmap using ANSI
C style.
David Xu
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01d801c2264e$db1b4fe0$ef01a8c0>