Date: Sun, 31 Jan 2021 20:12:42 +0100 From: Antoine Brodin <antoine@freebsd.org> To: Alex Richardson <arichardson@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, =?UTF-8?Q?T=C4=B3l_Coosemans?= <tijl@coosemans.org> Subject: Re: git: 7fa2f2a62f04 - main - Rename NO_WERROR -> MK_WERROR=no Message-ID: <CAALwa8m31K9C3Rw=9TeRDA5S1ZNkbPsc=jW_-kbaOqC%2BwL5iUg@mail.gmail.com> In-Reply-To: <20210110121242.1d9809ff@coosemans.org> References: <202101071105.107B5tUX011254@gitrepo.freebsd.org> <20210110121242.1d9809ff@coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 10, 2021 at 12:12 PM T=C4=B3l Coosemans <tijl@coosemans.org> wr= ote: > > On Thu, 7 Jan 2021 11:05:55 GMT Alex Richardson > <arichardson@FreeBSD.org> wrote: > > The branch main has been updated by arichardson: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D7fa2f2a62f04f095e1e27ad5= 5aa22a8f59b1df8f > > > > commit 7fa2f2a62f04f095e1e27ad55aa22a8f59b1df8f > > Author: Alex Richardson <Alexander.Richardson@cl.cam.ac.uk> > > AuthorDate: 2021-01-06 17:55:06 +0000 > > Commit: Alex Richardson <arichardson@FreeBSD.org> > > CommitDate: 2021-01-07 09:31:03 +0000 > > > > Rename NO_WERROR -> MK_WERROR=3Dno > > > > As suggested in D27598. This also supports MK_WERROR.clang=3Dno and > > MK_WERROR.gcc=3Dno to support the existing NO_WERROR.<compiler> use= s. > > > > Reviewed By: brooks > > Differential Revision: https://reviews.freebsd.org/D27601 > > --- > > diff --git a/share/mk/bsd.opts.mk b/share/mk/bsd.opts.mk > > index d0e7f1cb00ba..88c73cc6bfe4 100644 > > --- a/share/mk/bsd.opts.mk > > +++ b/share/mk/bsd.opts.mk > > @@ -65,7 +65,8 @@ __DEFAULT_YES_OPTIONS =3D \ > > SSP \ > > TESTS \ > > TOOLCHAIN \ > > - WARNS > > + WARNS \ > > + WERROR > > > > __DEFAULT_NO_OPTIONS =3D \ > > BIND_NOW \ > > @@ -103,7 +104,8 @@ __DEFAULT_DEPENDENT_OPTIONS =3D \ > > INSTALLLIB \ > > MAN \ > > PROFILE \ > > - WARNS > > + WARNS \ > > + WERROR > > .if defined(NO_${var}) > > .error "NO_${var} is defined, but deprecated. Please use MK_${var}=3Dn= o instead." > > MK_${var}:=3Dno > > NO_WERROR is also used by some ports [1] (which have to build against > multiple version of FreeBSD) and this turns it into an error. Can you > remove this change or turn it into a warning maybe? Changes to share/mk > should always go through a ports exp-run IMHO. Ping Alex Richardson? Antoine (with hat: portmgr)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8m31K9C3Rw=9TeRDA5S1ZNkbPsc=jW_-kbaOqC%2BwL5iUg>